This is an archive of the discontinued LLVM Phabricator instance.

[NFC] Move current live interval from being a class member of InsertPointAnalysis to query interfaces argument
ClosedPublic

Authored by wmi on May 23 2016, 11:12 AM.

Details

Summary

A following patch of http://reviews.llvm.org/D19884.

The patch move current live interval from being a class member of InsertPointAnalysis to its query interfaces argument, so the queries will be more independent and easier to use.

Diff Detail

Repository
rL LLVM

Event Timeline

wmi updated this revision to Diff 58120.May 23 2016, 11:12 AM
wmi retitled this revision from to [NFC] Move current live interval from being a class member of InsertPointAnalysis to query interfaces argument .
wmi updated this object.
wmi added a reviewer: MatzeB.
wmi set the repository for this revision to rL LLVM.
wmi added subscribers: llvm-commits, qcolombet, davidxl.
MatzeB accepted this revision.May 23 2016, 11:18 AM
MatzeB edited edge metadata.

LGTM. Nitpick below.

lib/CodeGen/SplitKit.h
72 ↗(On Diff #58120)

You should name the parameter MBB as you reference that in the comment.

This revision is now accepted and ready to land.May 23 2016, 11:18 AM

You should also change the title to something like LastInsertPointAnalysis: Move current live interval from being a class member to query interfaces argument; NFC (the thing at the beginning should be the area of the compiler, the NFC usually comes last).

This revision was automatically updated to reflect the committed changes.