Index: clang-tools-extra/trunk/clang-tidy/cppcoreguidelines/ProTypeMemberInitCheck.cpp =================================================================== --- clang-tools-extra/trunk/clang-tidy/cppcoreguidelines/ProTypeMemberInitCheck.cpp +++ clang-tools-extra/trunk/clang-tidy/cppcoreguidelines/ProTypeMemberInitCheck.cpp @@ -181,7 +181,7 @@ const auto *InitDecl = Init->isMemberInitializer() ? static_cast(Init->getMember()) - : Init->getBaseClass()->getAs()->getDecl(); + : Init->getBaseClass()->getAsCXXRecordDecl(); // Add all fields between current field up until the next intializer. for (; Decl != std::end(OrderedDecls) && *Decl != InitDecl; ++Decl) { @@ -401,7 +401,7 @@ // Remove any bases that were explicitly written in the initializer list. for (const CXXCtorInitializer *Init : Ctor->inits()) { if (Init->isBaseInitializer() && Init->isWritten()) - BasesToInit.erase(Init->getBaseClass()->getAs()->getDecl()); + BasesToInit.erase(Init->getBaseClass()->getAsCXXRecordDecl()); } if (BasesToInit.empty()) Index: clang-tools-extra/trunk/test/clang-tidy/cppcoreguidelines-pro-type-member-init.cpp =================================================================== --- clang-tools-extra/trunk/test/clang-tidy/cppcoreguidelines-pro-type-member-init.cpp +++ clang-tools-extra/trunk/test/clang-tidy/cppcoreguidelines-pro-type-member-init.cpp @@ -346,3 +346,14 @@ Template F; }; + +// This pathological template fails to compile if actually instantiated. It +// results in the check seeing a null RecordDecl when examining the base class +// initializer list. +template +class PositiveSelfInitialization : NegativeAggregateType +{ + PositiveSelfInitialization() : PositiveSelfInitialization() {} + // CHECK-MESSAGES: :[[@LINE-1]]:3: warning: constructor does not initialize these bases: NegativeAggregateType + // CHECK-FIXES: PositiveSelfInitialization() : NegativeAggregateType(), PositiveSelfInitialization() {} +};