This is an archive of the discontinued LLVM Phabricator instance.

Differential D19471

[TLI] Mark memset_pattern16 params nocapture.
ClosedPublic

Authored by ab on Apr 24 2016, 12:54 PM.

Details

Reviewers
echristo
mehdi_amini
Commits
rG44c19876c701: [InferAttrs] Mark memset_pattern16 params nocapture.
rL267760: [InferAttrs] Mark memset_pattern16 params nocapture.
Summary

Noticed while looking at D17598. I think it should also be nothrow, but there are lots of missing attributes already. I'm playing with tablegen so will do another pass over everything. For now, nocapture should help Mehdi.

Depends on D19470.

Diff Detail

Repository
rL LLVM

Event Timeline

ab updated this revision to Diff 54809.Apr 24 2016, 12:54 PM
ab retitled this revision from to [TLI] Mark memset_pattern16 params nocapture..
ab updated this object.
ab added reviewers: mehdi_amini, echristo.
ab added a parent revision: D19470: [TLI] Unify LibFunc attribute inference. NFCI..
ab added a subscriber: llvm-commits.
Herald added a subscriber: mehdi_amini. · View Herald TranscriptApr 24 2016, 12:54 PM
ab added a child revision: D17598: [LIR] Set attributes on memset_pattern16..Apr 24 2016, 12:56 PM
mehdi_amini accepted this revision.Apr 26 2016, 11:10 PM
mehdi_amini edited edge metadata.

LGTM, thanks.

This revision is now accepted and ready to land.Apr 26 2016, 11:10 PM
Closed by commit rL267760: [InferAttrs] Mark memset_pattern16 params nocapture. (authored by ab). · Explain WhyApr 27 2016, 12:10 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
llvm/
trunk/
lib/
Transforms/
Utils/
2 lines
test/
Transforms/
InferFunctionAttrs/
2 lines

Diff 55283

llvm/trunk/lib/Transforms/Utils/BuildLibCalls.cpp

Show First 20 Lines • Show All 684 Lines • ▼ Show 20 Lines case LibFunc::msvc_new_array_longlong: // new[](unsigned long long)
Changed |= setNonNull(F, AttributeSet::ReturnIndex); Changed |= setNonNull(F, AttributeSet::ReturnIndex);
Changed |= setDoesNotAlias(F, AttributeSet::ReturnIndex); Changed |= setDoesNotAlias(F, AttributeSet::ReturnIndex);
return Changed; return Changed;
//TODO: add LibFunc entries for: //TODO: add LibFunc entries for:
//case LibFunc::memset_pattern4: //case LibFunc::memset_pattern4:
//case LibFunc::memset_pattern8: //case LibFunc::memset_pattern8:
case LibFunc::memset_pattern16: case LibFunc::memset_pattern16:
Changed |= setOnlyAccessesArgMemory(F); Changed |= setOnlyAccessesArgMemory(F);
Changed |= setDoesNotCapture(F, 1);
Changed |= setDoesNotCapture(F, 2);
Changed |= setOnlyReadsMemory(F, 2); Changed |= setOnlyReadsMemory(F, 2);
return Changed; return Changed;
// int __nvvm_reflect(const char *) // int __nvvm_reflect(const char *)
case LibFunc::nvvm_reflect: case LibFunc::nvvm_reflect:
Changed |= setDoesNotAccessMemory(F); Changed |= setDoesNotAccessMemory(F);
Changed |= setDoesNotThrow(F); Changed |= setDoesNotThrow(F);
return Changed; return Changed;
▲ Show 20 Lines • Show All 305 Lines • Show Last 20 Lines

llvm/trunk/test/Transforms/InferFunctionAttrs/annotate.ll

Show All 19 Lines
; operator new routines ; operator new routines
declare i8* @_Znwj(i64) declare i8* @_Znwj(i64)
; CHECK: declare noalias nonnull i8* @_Znwj(i64) ; CHECK: declare noalias nonnull i8* @_Znwj(i64)
declare i8* @_Znwm(i64) declare i8* @_Znwm(i64)
; CHECK: declare noalias nonnull i8* @_Znwm(i64) ; CHECK: declare noalias nonnull i8* @_Znwm(i64)
declare void @memset_pattern16(i8*, i8*, i64) declare void @memset_pattern16(i8*, i8*, i64)
; CHECK: declare void @memset_pattern16(i8*, i8*, i64) ; CHECK: declare void @memset_pattern16(i8*, i8*, i64)
; CHECK-POSIX: declare void @memset_pattern16(i8*, i8* readonly, i64) [[G2:#[0-9]+]] ; CHECK-POSIX: declare void @memset_pattern16(i8* nocapture, i8* nocapture readonly, i64) [[G2:#[0-9]+]]
declare i32 @gettimeofday(i8*, i8*) declare i32 @gettimeofday(i8*, i8*)
; CHECK-POSIX: declare i32 @gettimeofday(i8* nocapture, i8* nocapture) [[G0:#[0-9]+]] ; CHECK-POSIX: declare i32 @gettimeofday(i8* nocapture, i8* nocapture) [[G0:#[0-9]+]]
; CHECK: attributes [[G0]] = { nounwind } ; CHECK: attributes [[G0]] = { nounwind }
; CHECK: attributes [[G1]] = { nounwind readonly } ; CHECK: attributes [[G1]] = { nounwind readonly }
; CHECK-POSIX: attributes [[G0]] = { nounwind } ; CHECK-POSIX: attributes [[G0]] = { nounwind }
; CHECK-POSIX: attributes [[G2]] = { argmemonly } ; CHECK-POSIX: attributes [[G2]] = { argmemonly }
declare i32 @__nvvm_reflect(i8*) declare i32 @__nvvm_reflect(i8*)
; CHECK-NVPTX: declare i32 @__nvvm_reflect(i8*) [[G0:#[0-9]+]] ; CHECK-NVPTX: declare i32 @__nvvm_reflect(i8*) [[G0:#[0-9]+]]
; CHECK-NVPTX: attributes [[G0]] = { nounwind readnone } ; CHECK-NVPTX: attributes [[G0]] = { nounwind readnone }