Page MenuHomePhabricator

Add missing qRegisterInfo option to gdbremote testcase
ClosedPublic

Authored by fjricci on Apr 5 2016, 4:13 PM.

Details

Summary

"gcc" is equivalent to "ehframe" in ProcessGDBRemote, but
only "ehframe" was a valid response in the test suite.

I know that "gcc" was replaced by "ehframe" in the test suite in D247741,
but since it hasn't been removed from ProcessGDBRemote, I'm
assuming that it's still a valid parameter.

Diff Detail

Event Timeline

fjricci updated this revision to Diff 52743.Apr 5 2016, 4:13 PM
fjricci retitled this revision from to Add missing qRegisterInfo option to gdbremote testcase.
fjricci updated this object.
fjricci added reviewers: jasonmolenda, tfiala, clayborg.
fjricci added subscribers: sas, lldb-commits.
jasonmolenda edited edge metadata.Apr 5 2016, 4:17 PM

Yes, good idea to add that. ProcessGDBRemote will need to accept "gcc" for at least a few years while old debugservers etc are floating around.

clayborg accepted this revision.Apr 6 2016, 9:35 AM
clayborg edited edge metadata.
This revision is now accepted and ready to land.Apr 6 2016, 9:35 AM
This revision was automatically updated to reflect the committed changes.