Index: ELF/SymbolTable.cpp =================================================================== --- ELF/SymbolTable.cpp +++ ELF/SymbolTable.cpp @@ -108,8 +108,10 @@ Obj->parse(DummyGroups); for (SymbolBody *Body : Obj->getNonLocalSymbols()) { Symbol *Sym = insert(Body); - if (!Sym->Body->isUndefined() && Body->isUndefined()) + if (!Sym->Body->isUndefined() && Body->isUndefined()) { + Sym->Body->setUsedInRegularObj(); continue; + } Sym->Body = Body; } ObjectFiles.push_back(std::move(Obj)); Index: ELF/Symbols.h =================================================================== --- ELF/Symbols.h +++ ELF/Symbols.h @@ -89,6 +89,8 @@ bool isInGot() const { return GotIndex != -1U; } bool isInPlt() const { return PltIndex != -1U; } + void setUsedInRegularObj() { IsUsedInRegularObj = true; } + template typename ELFT::uint getVA(typename ELFT::uint Addend = 0) const; @@ -319,7 +321,6 @@ std::unique_ptr getMember(); void setWeak() { IsWeak = true; } - void setUsedInRegularObj() { IsUsedInRegularObj = true; } private: ArchiveFile *File; Index: test/ELF/lto/undefined-puts.ll =================================================================== --- test/ELF/lto/undefined-puts.ll +++ test/ELF/lto/undefined-puts.ll @@ -3,9 +3,9 @@ ; RUN: ld.lld %t1.o -o %t1.so -shared ; RUN: llvm-as %s -o %t2.o ; RUN: ld.lld %t1.so %t2.o -m elf_x86_64 -o %t -; RUN: llvm-readobj -T %t | FileCheck %s +; RUN: llvm-readobj -dyn-symbols %t | FileCheck %s -layout = "e-m:e-i64:64-f80:128-n8:16:32:64-S128" +target datalayout = "e-m:e-i64:64-f80:128-n8:16:32:64-S128" target triple = "x86_64-unknown-linux-gnu" @.str = private unnamed_addr constant [6 x i8] c"blah\0A\00", align 1 @@ -16,5 +16,8 @@ } declare i32 @printf(i8*, ...) - Be sure that 'f' is kept and has weak linkage. -; CHECK: define weak void @f() + +; Check that puts symbol is present in the dynamic symbol table. +; CHECK: DynamicSymbols [ +; CHECK: Symbol { +; CHECK: Name: puts@