Index: clang-tidy/readability/RedundantStringCStrCheck.cpp =================================================================== --- clang-tidy/readability/RedundantStringCStrCheck.cpp +++ clang-tidy/readability/RedundantStringCStrCheck.cpp @@ -85,23 +85,29 @@ if (!getLangOpts().CPlusPlus) return; - Finder->addMatcher( + // Match string constructor. + const auto StringConstructorExpr = expr(anyOf( + cxxConstructExpr( + argumentCountIs(1), + hasDeclaration(cxxMethodDecl(hasName(StringConstructor)))), cxxConstructExpr( - hasDeclaration(cxxMethodDecl(hasName(StringConstructor))), argumentCountIs(2), - // The first argument must have the form x.c_str() or p->c_str() - // where the method is string::c_str(). We can use the copy - // constructor of string instead (or the compiler might share - // the string object). - hasArgument(0, cxxMemberCallExpr( - callee(memberExpr().bind("member")), - callee(cxxMethodDecl(hasName(StringCStrMethod))), - on(expr().bind("arg"))) - .bind("call")), - // The second argument is the alloc object which must not be - // present explicitly. - hasArgument(1, cxxDefaultArgExpr())), + hasDeclaration(cxxMethodDecl(hasName(StringConstructor))), + // If present, the second argument is the alloc object which must not + // be present explicitly. + hasArgument(1, cxxDefaultArgExpr())))); + + // Match a call to the string 'c_str()' method. + const auto StringCStrCallExpr = cxxMemberCallExpr( + callee(memberExpr().bind("member")), + callee(cxxMethodDecl(hasName(StringCStrMethod))), + on(expr().bind("arg"))).bind("call"); + + Finder->addMatcher( + cxxConstructExpr(StringConstructorExpr, + hasArgument(0, StringCStrCallExpr)), this); + Finder->addMatcher( cxxConstructExpr( // Implicit constructors of these classes are overloaded @@ -117,11 +123,7 @@ // a constructor from string which is more efficient (avoids // strlen), so we can construct StringRef from the string // directly. - hasArgument(0, cxxMemberCallExpr( - callee(memberExpr().bind("member")), - callee(cxxMethodDecl(hasName(StringCStrMethod))), - on(expr().bind("arg"))) - .bind("call"))), + hasArgument(0, StringCStrCallExpr)), this); } Index: test/clang-tidy/readability-redundant-string-cstr-msvc.cpp =================================================================== --- /dev/null +++ test/clang-tidy/readability-redundant-string-cstr-msvc.cpp @@ -0,0 +1,43 @@ +// RUN: %check_clang_tidy %s readability-redundant-string-cstr %t + +namespace std { +template +class allocator {}; +template +class char_traits {}; +template +struct basic_string { + basic_string(); + // MSVC headers define two constructors instead of using optional arguments. + basic_string(const C *p); + basic_string(const C *p, const A &a); + const C *c_str() const; +}; +typedef basic_string, std::allocator> string; +} +namespace llvm { +struct StringRef { + StringRef(const char *p); + StringRef(const std::string &); +}; +} + +void f1(const std::string &s) { + f1(s.c_str()); + // CHECK-MESSAGES: :[[@LINE-1]]:6: warning: redundant call to `c_str()` [readability-redundant-string-cstr] + // CHECK-FIXES: {{^ }}f1(s);{{$}} +} +void f2(const llvm::StringRef r) { + std::string s; + f2(s.c_str()); + // CHECK-MESSAGES: :[[@LINE-1]]:6: warning: redundant call {{.*}} + // CHECK-FIXES: {{^ }}std::string s;{{$}} + // CHECK-FIXES-NEXT: {{^ }}f2(s);{{$}} +} +void f3(const llvm::StringRef &r) { + std::string s; + f3(s.c_str()); + // CHECK-MESSAGES: :[[@LINE-1]]:6: warning: redundant call {{.*}} + // CHECK-FIXES: {{^ }}std::string s;{{$}} + // CHECK-FIXES-NEXT: {{^ }}f3(s);{{$}} +}