This is an archive of the discontinued LLVM Phabricator instance.

Use shallow clones in build-llvm.py.
ClosedPublic

Authored by sas on Feb 18 2016, 4:37 PM.

Download Raw Diff

Details

Reviewers

spyffe
tfiala

Commits

rGc691b14a416b: Use shallow clones in build-llvm.py.
rLLDB262513: Use shallow clones in build-llvm.py.
rL262513: Use shallow clones in build-llvm.py.

Summary

This makes cloning (and therefore the whole build) faster.
The checkout step goes from ~4m to ~30s on my host.

Diff Detail

Repository: rL LLVM

Event Timeline

sas updated this revision to Diff 48427.Feb 18 2016, 4:37 PM

sas retitled this revision from to Use shallow clones in build-llvm.py..

sas updated this object.

sas added a reviewer: tfiala.

sas added a subscriber: lldb-commits.

+Sean

Sean, I'm okay with this for now. You know my changes coming down the pipe, and I can add a configuration setting for the git side that lets us optionally add in the history truncation. Thoughts?

(Stephane, I've got a change in the works that is currently backed up behind some other things, but it allows better mapping of Xcode lldb configuration to llvm/clang configuration, and includes specifying if svn or git should be used. It will actually default to svn. Most of the change is in github.com/tfiala/lldb on the tfiala-master branch but I won't have time to clean it up for a little while here).

Ah, sounds like a cool change. Should we wait until your stuff goes in or
are you still ok with submitting my patch in the meantime?

Nah - please go ahead and submit it. I'll just make sure I add the ability
to specify arbitrary git flags for the git part so you can have this when I
put the new change in.

In D17425#363665, @tfiala wrote:

Nah - please go ahead and submit it. I'll just make sure I add the ability
to specify arbitrary git flags for the git part so you can have this when I
put the new change in.

Haha sorry poor English after I reread the question. More appropriate answer:

"Yes - please feel free to submit your addition."

This revision is now accepted and ready to land.Feb 27 2016, 3:19 PM

Closed by commit rL262513: Use shallow clones in build-llvm.py. (authored by sas). · Explain WhyMar 2 2016, 12:58 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents

Path

Size

lldb/

trunk/

scripts/

Xcode/

lldbbuild.py

2 lines

Diff 49663

lldb/trunk/scripts/Xcode/lldbbuild.py

	Show First 20 Lines • Show All 59 Lines • ▼ Show 20 Lines
	class Git:			class Git:
	def __init__ (self, spec):			def __init__ (self, spec):
	self.spec = spec			self.spec = spec
	def status (self):			def status (self):
	return run_in_directory(["git", "branch", "-v"], self.spec['root'])			return run_in_directory(["git", "branch", "-v"], self.spec['root'])
	def diff (self):			def diff (self):
	return run_in_directory(["git", "diff"], self.spec['root'])			return run_in_directory(["git", "diff"], self.spec['root'])
	def check_out (self):			def check_out (self):
	run_in_directory(["git", "clone", self.spec['url'], self.spec['root']], lldb_source_path())			run_in_directory(["git", "clone", "--depth=1", self.spec['url'], self.spec['root']], lldb_source_path())
	run_in_directory(["git", "fetch", "--all"], self.spec['root'])			run_in_directory(["git", "fetch", "--all"], self.spec['root'])
	run_in_directory(["git", "checkout", self.spec['ref']], self.spec['root'])			run_in_directory(["git", "checkout", self.spec['ref']], self.spec['root'])

	class SVN:			class SVN:
	def __init__ (self, spec):			def __init__ (self, spec):
	self.spec = spec			self.spec = spec
	def status (self):			def status (self):
	return run_in_directory(["svn", "info"], self.spec['root'])			return run_in_directory(["svn", "info"], self.spec['root'])
	▲ Show 20 Lines • Show All 59 Lines • Show Last 20 Lines