Fix the use of -j in "make check-all"

[kparzysz]

Summary

getLLVMCMakeBuildFactory constructs the -jN option incorrectly when running "make check-all".

Example:
http://lab.llvm.org:8011/builders/llvm-hexagon-elf/builds/26076/steps/test-llvm/logs/stdio

make check-all VERBOSE=1 'LIT_ARGS=-v -j 16'
 in dir /var/lib/buildbot/slaves/hexagon-build-03/llvm-hexagon-elf/llvm.obj (timeout 1200 secs)
 watching logfiles {}
 argv: ['make', 'check-all', 'VERBOSE=1', 'LIT_ARGS=-v -j 16']

Specifically, the -jN option is a part of LIT_ARGS, not the make invocation.

[gkistanova]

zorg/buildbot/builders/LLVMBuilder.py

218 ↗

(On Diff #48370)

This wouldn't work as you expect.
You need to use WithProperties similar to all the other places in this file where the jobs param is used.

[kparzysz]

Used "WithProperties" to pass the arguments to the build step.

[gkistanova]

LGTM

zorg/trunk/zorg/buildbot/builders/LLVMBuilder.py

f.addStep(
             env             = merged_env,
             timeout         = timeout * 60))
     if test:
         litTestArgs = '-v -j %s' % jobs
         f.addStep(
             LitTestCommand(
                 name            = 'test-llvm',
                 command         = [make, "check-all", "VERBOSE=1",
+                                   WithProperties("-j%s" % jobs),
                                    WithProperties("LIT_ARGS=%s" % litTestArgs)],
                 description     = ["testing", "llvm"],
                 descriptionDone = ["test",    "llvm"],
                 workdir         = llvm_objdir,
                 env             = merged_env))
     return f