Fix SocketTest on Windows

[zturner]

Summary

Hi Vince,

I'm not sure why the #if _WIN32 check is even in there to begin with, but I tested on Windows 7 and Windows 10 and in both cases the output is that of the non _WIN32 path. Were you seeing this other value in practice?

In any case, this patch fixes it for me, so I'm curious to see how this came about.

[labath]

We are not running these unittests on windows at the moment. You are the windows maintainer, so if you say this is working for you then remove it. We can always fix things up later...

[labath]

So I ran the tests on windows (W7 Enterprise) now and I did indeed get the long "0:0:...:1" version here instead of "::1". Maybe we should just accept both versions as correct?

[zturner]

Yea that works

lldb/trunk/unittests/Host/SocketAddressTest.cpp

TEST_F (SocketAddressTest, Set)
     ASSERT_STREQ ("127.0.0.1", sa.GetIPAddress ().c_str ());
     ASSERT_EQ (1138, sa.GetPort ());
 
     ASSERT_TRUE (sa.SetToAnyAddress (AF_INET, 0));
     ASSERT_STREQ ("0.0.0.0", sa.GetIPAddress ().c_str ());
     ASSERT_EQ (0, sa.GetPort ());
 
     ASSERT_TRUE (sa.SetToLocalhost (AF_INET6, 1139));
-#ifdef _WIN32
-    ASSERT_STREQ ("0:0:0:0:0:0:0:1", sa.GetIPAddress ().c_str ());
-#else
     ASSERT_STREQ ("::1", sa.GetIPAddress ().c_str ());
-#endif
     ASSERT_EQ (1139, sa.GetPort ());
 }
 
 #ifdef _WIN32
 
 // we need to test our inet_ntop implementation for Windows XP
 const char* inet_ntop (int af, const void * src,
                         char * dst, socklen_t size);