This is an archive of the discontinued LLVM Phabricator instance.

[ARM] Emit trap instruction using .inst directive
ClosedPublic

Authored by labrinea on Jan 28 2016, 7:21 AM.

Details

Diff Detail

Repository
rL LLVM

Event Timeline

labrinea updated this revision to Diff 46269.Jan 28 2016, 7:21 AM
labrinea retitled this revision from to [ARM] Emit trap instruction using .inst directive.
labrinea updated this object.
labrinea added inline comments.Jan 28 2016, 7:25 AM
test/CodeGen/ARM/debugtrap.ll
13 ↗(On Diff #46269)

Not sure why was this valid. "trap" was present only in a comment: '@ trap'

test/CodeGen/ARM/trap.ll
4 ↗(On Diff #46269)

We shouldn't be testing -mtriple=armv7-unknown-nacl in CodeGen, it is a Clang thing. -mattr=+nacl-trap is the right thing to test in the back-end.

rengolin accepted this revision.Jan 28 2016, 9:29 AM
rengolin edited edge metadata.

Hi Alexandros,

The test seems to have been vague on purpose (because it was using .short/.long), but using .inst is definitely the right way.

LGTM. Thanks!

This revision is now accepted and ready to land.Jan 28 2016, 9:29 AM
This revision was automatically updated to reflect the committed changes.