Delete char const** swig typemaps

[zturner]

Summary

We already have char** typemaps and they are exact copy-pastes. No reason to have both, I tested this and diffed the generated code and it doesn't seem to be any different with this change.

[granata.enrico]

Did you mean to delete the tid_t typemap as well?

Assuming there truly are identical typemaps and these are just copies, and everything works just as well when they are removed, I have no objection

[zturner]

I just moved tid to the bottom because it was in the middle of the in, out, and typecheck versions of the char** typemap. So I wanted to group them all together.

Anyway, yea this didn't seem too controversial to me but I figured I'd throw it up here for review in case you knew of some quirk of swig with regards to typematching and constness. But yea, I tested it and the generated code is semantically identical.

If anything breaks it will probably be due to a swig version difference, so let me know after I commit since I'm using 3.x

[granata.enrico]

Ops, sorry, didn't notice the tid_t type map was actually added back later on in the patch. My bad.

I'm going to accept this for now, with the caveat that we'll need to work through it and possibly revert if it breaks on our SWIG. Unlikely that that happens though.

[Eugene.Zelenko]

Committed in r257670.

scripts/Python/python-typemaps.swig

   }
 }
 
-%typemap(in) lldb::tid_t {
-  using namespace lldb_private;
-  if (PythonInteger::Check($input))
-  {
-    PythonInteger py_int(PyRefType::Borrowed, $input);
-    $1 = static_cast<lldb::tid_t>(py_int.GetInteger());
-  }
-  else
-  {
-    PyErr_SetString(PyExc_ValueError, "Expecting an integer");
-    return nullptr;
-  }
-}
-
 %typemap(typecheck) char ** {
   /* Check if is a list  */
   $1 = 1;

   $result = list.release();
 }
 
-%typemap(in) char const ** {
-  /* Check if is a list  */
-  using namespace lldb_private;
-  if (PythonList::Check($input)) {
-    PythonList py_list(PyRefType::Borrowed, $input);
-    int size = py_list.GetSize();
-
-    $1 = (char**)malloc((size+1)*sizeof(char*));
-    for (int i = 0; i < size; i++) {
-      auto py_str = py_list.GetItemAtIndex(i).AsType<PythonString>();
-      if (!py_str.IsAllocated()) {
-        PyErr_SetString(PyExc_TypeError,"list must contain strings");
-        free($1);
-        return nullptr;
-      }
-      $1[i] = const_cast<char*>(py_str.GetString().data());
-    }
-
-    $1[size] = 0;
-  } else if ($input == Py_None) {
-    $1 = nullptr;
-  } else {
-    PyErr_SetString(PyExc_TypeError,"not a list");
-    return nullptr;
-  }
-}
 
-%typemap(typecheck) char const ** {
+%typemap(in) lldb::tid_t {
   using namespace lldb_private;
-  /* Check if is a list  */
-  $1 = 1;
-  if (PythonList::Check($input)) {
-    PythonList list(PyRefType::Borrowed, $input);
-    int size = list.GetSize();
-    int i = 0;
-    for (i = 0; i < size; i++) {
-      PythonString s = list.GetItemAtIndex(i).AsType<PythonString>();
-      if (!s.IsAllocated()) { $1 = 0; }
-    }
+  if (PythonInteger::Check($input))
+  {
+    PythonInteger py_int(PyRefType::Borrowed, $input);
+    $1 = static_cast<lldb::tid_t>(py_int.GetInteger());
   }
   else
   {
-    $1 = ( ($input == Py_None) ? 1 : 0);
-  }
-}
-
-%typemap(freearg) char const ** {
-  free((char *) $1);
-}
-
-%typemap(out) char const ** {
-  int len;
-  int i;
-  len = 0;
-  while ($1[len]) len++;
-  using namespace lldb_private;
-  PythonList list(len);
-  for (i = 0; i < len; i++) {
-    PythonString str($1[i]);
-    list.SetItemAtIndex(i, str);
+    PyErr_SetString(PyExc_ValueError, "Expecting an integer");
+    return nullptr;
   }
-  $result = list.release();
 }
 
 /* Typemap definitions to allow SWIG to properly handle char buffer. */