Add LogDump methods to lldb_private::StringList to ease printing of iterable string containers

[ldrumm]

Summary

Prompted by @gclayborg in review http://reviews.llvm.org/D15527

[clayborg]

See inlined comments.

source/Core/StringList.cpp

365–370

Since this is going out to a Log, we should have all the strings together in one log line. I would suggest making a local StreamString object and using StreamString::Printf() instead of the "log->Debug" calls, and then output the stream all at once:

StreamString strm;
if (name)
    strm.Printf("Begin %s:\n", name);
for (const auto &s : m_strings)
{
    strm.Indent();
    strm.Printf("%s\n", s.c_str());
}
if (name)
    strm.Printf("End %s.\n", name);
log->Debug("%s", strm.GetData());

Otherwise we might get the strings out of order and intermixed with other log lines.

[ldrumm]

Addresses @clayborg's feedback in http://reviews.llvm.org/D15773

include/lldb/Core/StringList.h

     operator << (const char* str);
 
     StringList&
+    operator << (const std::string &s);
+
+    StringList&
     operator << (StringList strings);
     
     // Copy assignment for a vector of strings

 
     // Static helper to convert an iterable of strings to a StringList, and then
     // dump it with the semantics of the `LogDump` method.
-    template<typename T> static void LogDump(Log *log, T s_iterable, const char *name = nullptr);
+    template<typename T> static void LogDump(Log *log, T s_iterable, const char *name = nullptr)
+    {
+        if (!log)
+            return;
+        // Make a copy of the iterable as a StringList
+        StringList l{};
+        for (const auto &s : s_iterable)
+            l << s;
+
+        l.LogDump(log, name);
+    }
 private:
     STLStringArray m_strings;
 };

source/Core/StringList.cpp

 }
 
 StringList&
+StringList::operator << (const std::string& str)
+{
+    AppendString(str);
+    return *this;
+}
+
+StringList&
 StringList::operator << (StringList strings)
 {
     AppendList(strings);

     if (name)
         log->Debug("End %s.", name);
 }
-
-template<typename T>void
-StringList::LogDump(Log *log, T s_iterable, const char *name)
-{
-    if (!log)
-        return;
-    // Make a copy of the iterable as a StringList
-    StringList l{};
-    for (const auto &s : s_iterable)
-        l << s;
-
-    l.LogDump(log, name);
-}