Index: lib/CodeGen/BranchFolding.cpp =================================================================== --- lib/CodeGen/BranchFolding.cpp +++ lib/CodeGen/BranchFolding.cpp @@ -744,24 +744,34 @@ return true; } -static bool hasIdenticalMMOs(const MachineInstr *MI1, const MachineInstr *MI2) { +// Add MI1's MMOs to MI2's. +static void mergeMMOs(MachineInstr *MI1, MachineInstr *MI2) { auto I1 = MI1->memoperands_begin(), E1 = MI1->memoperands_end(); auto I2 = MI2->memoperands_begin(), E2 = MI2->memoperands_end(); - if ((E1 - I1) != (E2 - I2)) - return false; - for (; I1 != E1; ++I1, ++I2) { - if (**I1 != **I2) - return false; + if ((E1 - I1) == 0) + return; + + for (; I1 != E1; ++I1) { + bool IsDupMMO = false; + for (; I2 != E2; ++I2) { + if (**I1 == **I2) { + IsDupMMO = true; + break; + } + } + if (IsDupMMO == false) { + MachineFunction *MF = MI1->getParent()->getParent(); + MI2->addMemOperand(*MF, *I1); + I2 = MI2->memoperands_begin(); + E2 = MI2->memoperands_end(); + } } - return true; } static void -removeMMOsFromMemoryOperations(MachineBasicBlock::iterator MBBIStartPos, +mergeMMOsFromMemoryOperations(MachineBasicBlock::iterator MBBIStartPos, MachineBasicBlock &MBBCommon) { - // Remove MMOs from memory operations in the common block - // when they do not match the ones from the block being tail-merged. - // This ensures later passes conservatively compute dependencies. + // Merge MMOs from memory operations in the common block MachineBasicBlock *MBB = MBBIStartPos->getParent(); // Note CommonTailLen does not necessarily matches the size of // the common BB nor all its instructions because of debug @@ -792,8 +802,7 @@ assert(MBBICommon->isIdenticalTo(&*MBBI) && "Expected matching MIIs!"); if (MBBICommon->mayLoad() || MBBICommon->mayStore()) - if (!hasIdenticalMMOs(&*MBBI, &*MBBICommon)) - MBBICommon->clearMemRefs(); + mergeMMOs(&*MBBI, &*MBBICommon); ++MBBI; ++MBBICommon; @@ -913,8 +922,8 @@ continue; DEBUG(dbgs() << "BB#" << SameTails[i].getBlock()->getNumber() << (i == e-1 ? "" : ", ")); - // Remove MMOs from memory operations as needed. - removeMMOsFromMemoryOperations(SameTails[i].getTailStartPos(), *MBB); + // Merge MMOs from memory operations as needed. + mergeMMOsFromMemoryOperations(SameTails[i].getTailStartPos(), *MBB); // Hack the end off BB i, making it jump to BB commonTailIndex instead. ReplaceTailWithBranchTo(SameTails[i].getTailStartPos(), MBB); // BB i is no longer a predecessor of SuccBB; remove it from the worklist.