This is an archive of the discontinued LLVM Phabricator instance.

Differential D14089

Avoid using `..` in paths for include dirs.
ClosedPublic

Authored by sas on Oct 26 2015, 1:21 PM.

Details

Reviewers
dawn
zturner
brucem
Commits
rGd1517e184c6c: Avoid using `..` in paths for include dirs.
rLLDB251530: Avoid using `..` in paths for include dirs.
rL251530: Avoid using `..` in paths for include dirs.
Summary

This breaks when using a symlink from llvm/tools/lldb to the lldb source
tree, instead of cloning directly as a child. With this change, we can
build properly, even when using links.

Diff Detail

Repository
rL LLVM

Event Timeline

sas updated this revision to Diff 38454.Oct 26 2015, 1:21 PM
sas retitled this revision from to Avoid using `..` in paths for include dirs..
sas updated this object.
sas added reviewers: dawn, brucem.
sas added a subscriber: lldb-commits.
zturner accepted this revision.Oct 26 2015, 1:21 PM
zturner added a reviewer: zturner.
This revision is now accepted and ready to land.Oct 26 2015, 1:21 PM
Closed by commit rL251530: Avoid using `..` in paths for include dirs. (authored by sas). · Explain WhyOct 28 2015, 10:37 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
lldb/
trunk/
cmake/
modules/
2 lines

Diff 38670

lldb/trunk/cmake/modules/LLDBConfig.cmake

Show First 20 Lines • Show All 188 Lines • ▼ Show 20 Lines
endif() endif()
if (LLDB_DISABLE_PYTHON) if (LLDB_DISABLE_PYTHON)
unset(PYTHON_INCLUDE_DIRS) unset(PYTHON_INCLUDE_DIRS)
unset(PYTHON_LIBRARY) unset(PYTHON_LIBRARY)
add_definitions( -DLLDB_DISABLE_PYTHON ) add_definitions( -DLLDB_DISABLE_PYTHON )
endif() endif()
include_directories(../clang/include) include_directories(${CMAKE_SOURCE_DIR}/tools/clang/include)
include_directories("${CMAKE_CURRENT_BINARY_DIR}/../clang/include") include_directories("${CMAKE_CURRENT_BINARY_DIR}/../clang/include")
# Disable GCC warnings # Disable GCC warnings
check_cxx_compiler_flag("-Wno-deprecated-declarations" check_cxx_compiler_flag("-Wno-deprecated-declarations"
CXX_SUPPORTS_NO_DEPRECATED_DECLARATIONS) CXX_SUPPORTS_NO_DEPRECATED_DECLARATIONS)
if (CXX_SUPPORTS_NO_DEPRECATED_DECLARATIONS) if (CXX_SUPPORTS_NO_DEPRECATED_DECLARATIONS)
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wno-deprecated-declarations") set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wno-deprecated-declarations")
endif () endif ()
▲ Show 20 Lines • Show All 187 Lines • Show Last 20 Lines