This is an archive of the discontinued LLVM Phabricator instance.

Fix build with python disabled after r249597
ClosedPublic

Authored by loladiro on Oct 8 2015, 7:31 PM.

Details

Summary

r249597 introduced a usage of GetTypeSummary in lldb-mi. That function used to only be available when python is enabled. However, it doesn't seem like there's a reason for that anymore since that is now dealt with a different abstraction layer.

Diff Detail

Repository
rL LLVM

Event Timeline

loladiro updated this revision to Diff 36918.Oct 8 2015, 7:31 PM
loladiro retitled this revision from to Fix build with python disabled after r249597.
loladiro updated this object.
loladiro set the repository for this revision to rL LLVM.
loladiro added a subscriber: lldb-commits.
brucem added a subscriber: brucem.Oct 8 2015, 8:48 PM

Getting rid of a lot of the #ifndef LLDB_DISABLE_PYTHON checks had been on my list of things I wanted to clean up. Since you regularly build with this configuration (and I never do), I suspect that a lot more of those checks could go away, but maybe that's best left for follow up patches?

evgeny777 accepted this revision.Oct 8 2015, 11:48 PM
evgeny777 edited edge metadata.

Lgtm

This revision is now accepted and ready to land.Oct 8 2015, 11:48 PM
clayborg accepted this revision.Oct 9 2015, 10:18 AM
clayborg edited edge metadata.

Wait for the OK from Enrico as well to verify this is OK.

granata.enrico accepted this revision.Oct 15 2015, 10:39 AM
granata.enrico edited edge metadata.

Looks fine to me

This revision was automatically updated to reflect the committed changes.