This is an archive of the discontinued LLVM Phabricator instance.

[darwin] [builtins] Stop generating cc_kext_ios5 and move iOS architectures out of cc_kext into cc_kext_ios
ClosedPublic

Authored by beanz on Sep 23 2015, 11:38 AM.

Details

Summary

This corresponds to a patch to compiler-rt (D13112).

Xcode 7 doesn't support targeting iOS5 and earlier. Instead of just dropping cc_kext_ios5, I've repurposed it to cc_kext_ios, and I'm pulling the iOS architectures out of cc_kext. Putting OS X and iOS slices inside the same archive was just odd.

Diff Detail

Repository
rL LLVM

Event Timeline

beanz updated this revision to Diff 35538.Sep 23 2015, 11:38 AM
beanz retitled this revision from to [darwin] [builtins] Stop generating cc_kext_ios5 and move iOS architectures out of cc_kext into cc_kext_ios.
beanz updated this object.
beanz added reviewers: bogner, bob.wilson.
beanz added a subscriber: cfe-commits.
bob.wilson accepted this revision.Sep 23 2015, 11:51 AM
bob.wilson edited edge metadata.

Good idea. The patch looks good. It will need to be coordinated with a change to compiler_rt build cc_kext_ios.a, though. Thanks for cleaning this up.

This revision is now accepted and ready to land.Sep 23 2015, 11:51 AM
This revision was automatically updated to reflect the committed changes.