This is an archive of the discontinued LLVM Phabricator instance.

Handle new types in ClangASTContext::GetEncoding
ClosedPublic

Authored by emaste on Sep 23 2015, 6:38 AM.

Details

Diff Detail

Repository
rL LLVM

Event Timeline

emaste updated this revision to Diff 35488.Sep 23 2015, 6:38 AM
emaste retitled this revision from to Handle OMPArraySection in ClangASTContext::GetEncoding.
emaste updated this object.
emaste added reviewers: granata.enrico, clayborg, brucem.
emaste added a subscriber: lldb-commits.

Oh, it seems there are more new types added after I first made this change:

../tools/lldb/source/Symbol/ClangASTContext.cpp:4445:21: warning: 10 enumeration values not handled in switch: 'OCLImage2dDepth', 'OCLImage2dArrayDepth', 'OCLImage2dMSAA'... [-Wswitch]
clayborg edited edge metadata.Sep 23 2015, 10:41 AM

You need to add more diffs to take care of the extra enums or does this patch include those already?

emaste updated this revision to Diff 35532.Sep 23 2015, 11:13 AM
emaste retitled this revision from Handle OMPArraySection in ClangASTContext::GetEncoding to Handle new types in ClangASTContext::GetEncoding.
emaste edited edge metadata.

More new types added after my initial patch.

clayborg accepted this revision.Sep 23 2015, 11:31 AM
clayborg edited edge metadata.
This revision is now accepted and ready to land.Sep 23 2015, 11:31 AM
emaste closed this revision.Sep 23 2015, 11:38 AM
This revision was automatically updated to reflect the committed changes.