Fix link failures when BUILD_SHARED_LIBS=ON.

[dsanders]

This patch does the trick for me but I'm not certain it's the right fix overall. Could someone take a look?

[labath]

Thanks for the patch.

LLDBDependencies.cmake sets LLDB_SYSTEM_LIBS to the list of libraries lldb depends on. Could you check if it is not sufficient to add this to the list of dependencies? I'd like to avoid replicating this if(LLDB_DISABLE_XXX) logic if it is possible.

[krytarowski]

tools/lldb-server/CMakeLists.txt

40

This approach of linking external entities is broken on NetBSD (pkgsrc). pkgsrc installs libraries under custom prefix and target_link_libraries is deaf to it. There is additional issue with handling includes, I need for it `config.h`.

The correct one is to use find_package(Curses) and link against ${CURSES_LIBRARIES}

if (NOT LLDB_DISABLE_CURSES)
    set(CURSES_NEED_NCURSES TRUE)
    find_package(Curses REQUIRED)

    find_library(NCURSES_PANEL_LIBRARY NAMES panel DOC "The ncureses panel library")
    if (CURSES_FOUND)
        # Add panels to the library path
        set (CURSES_LIBRARIES ${CURSES_LIBRARIES} ${NCURSES_PANEL_LIBRARY})
    endif ()
endif ()

I'm in process of preparing a proper ncurses handling, CMake is done and with autotools/gmake I need to research it bit more (properly add config.h in the autotools target).

[dsanders]

Pavel's suggestion to use LLDB_SYSTEM_LIBS works for me. Updated the patch.

[labath]

Committed as r247991. We can tweak this later if needed after Kamil's changes go in.

tools/lldb-server/CMakeLists.txt

 if (BUILD_SHARED_LIBS )
   add_lldb_executable(lldb-server
     lldb-gdbserver.cpp
     lldb-platform.cpp
     lldb-server.cpp
     LLDBServerUtilities.cpp
     )
 
-  target_link_libraries(lldb-server liblldb)
+  target_link_libraries(lldb-server liblldb dl)
   if (HAVE_LIBPTHREAD)
     target_link_libraries(lldb-server pthread)
   endif ()
+  if (LIBXML2_FOUND)
+    target_link_libraries(lldb-server xml2)
+  endif()
+  if (NOT LLDB_DISABLE_LIBEDIT)
+    target_link_libraries(lldb-server edit)
+  endif()
+  if (NOT LLDB_DISABLE_CURSES)
+    target_link_libraries(lldb-server ncurses panel)
+  endif()
 else()
   add_lldb_executable(lldb-server
     lldb-gdbserver.cpp
     lldb-platform.cpp
     lldb-server.cpp
     LLDBServerUtilities.cpp
     ../../source/lldb.cpp
     )