This is an archive of the discontinued LLVM Phabricator instance.

Fix lldb build on older OSX versions after svn commit r244716
ClosedPublic

Authored by dawn on Aug 26 2015, 6:35 PM.

Details

Summary

Older OSX versions don't define NSOperatingSystemVersion, so building lldb gets:

../tools/lldb/tools/debugserver/source/MacOSX/MachProcess.mm:2032:5: error: unknown type name 'NSOperatingSystemVersion'
    NSOperatingSystemVersion vers = [[NSProcessInfo processInfo] operatingSystemVersion];
    ^

This patch fixes the build by having GetOSVersionNumbers return false if ENVIRONMENT_MAC_OS_X_VERSION_MIN_REQUIRED < 101000, causing lldb to behave the same as it did before this patch.

Diff Detail

Repository
rL LLVM

Event Timeline

dawn updated this revision to Diff 33294.Aug 26 2015, 6:35 PM
dawn retitled this revision from to Fix lldb build on older OSX versions after svn commit r244716.
dawn updated this object.
dawn added a reviewer: jasonmolenda.
dawn set the repository for this revision to rL LLVM.
dawn added a subscriber: lldb-commits.
jasonmolenda accepted this revision.Aug 26 2015, 8:03 PM
jasonmolenda edited edge metadata.

Looks good, thanks, I wasn't sure about whether this API would be available on older releases.

This revision is now accepted and ready to land.Aug 26 2015, 8:03 PM
This revision was automatically updated to reflect the committed changes.