Index: llvm/trunk/lib/CodeGen/SelectionDAG/FastISel.cpp =================================================================== --- llvm/trunk/lib/CodeGen/SelectionDAG/FastISel.cpp +++ llvm/trunk/lib/CodeGen/SelectionDAG/FastISel.cpp @@ -1415,7 +1415,11 @@ if (FuncInfo.BPI) BranchWeight = FuncInfo.BPI->getEdgeWeight(BranchBB, TrueMBB->getBasicBlock()); - FuncInfo.MBB->addSuccessor(TrueMBB, BranchWeight); + // Add TrueMBB as successor unless it is equal to the FalseMBB: This can + // happen in degenerate IR and MachineIR forbids to have a block twice in the + // successor/predecessor lists. + if (TrueMBB != FalseMBB) + FuncInfo.MBB->addSuccessor(TrueMBB, BranchWeight); fastEmitBranch(FalseMBB, DbgLoc); } Index: llvm/trunk/test/CodeGen/X86/fast-isel-cmp-branch.ll =================================================================== --- llvm/trunk/test/CodeGen/X86/fast-isel-cmp-branch.ll +++ llvm/trunk/test/CodeGen/X86/fast-isel-cmp-branch.ll @@ -1,5 +1,18 @@ -; RUN: llc -O0 -mtriple=x86_64-linux -asm-verbose=false < %s | FileCheck %s -; RUN: llc -O0 -mtriple=x86_64-windows-itanium -asm-verbose=false < %s | FileCheck %s +; RUN: llc -O0 -mtriple=x86_64-linux -asm-verbose=false -verify-machineinstrs < %s | FileCheck %s +; RUN: llc -O0 -mtriple=x86_64-windows-itanium -asm-verbose=false -verify-machineinstrs < %s | FileCheck %s + +; Fast-isel mustn't add a block to the MBB successor/predecessor list twice. +; The machine verifier will catch and complain about this case. +; CHECK-LABEL: baz +; CHECK: retq +define void @baz() { +entry: + br i1 undef, label %exit, label %exit + +exit: + ret void +} + ; rdar://8337108 ; Fast-isel shouldn't try to look through the compare because it's in a