This is an archive of the discontinued LLVM Phabricator instance.

AMDGPU/GlobalISel: Fix legalization failure for s65 shifts
ClosedPublic

Authored by arsenm on Jan 17 2022, 6:42 AM.

Details

Summary

This was trying to clamp s65 down to s32, which wasn't handled so we
need to promote all the way to s128 first. Having to order the
legalization rules in just the right way is rather dissatisfying, but
I'm not sure how smart the legalizer should be in trying to interpret
the rules.

Diff Detail

Event Timeline

arsenm created this revision.Jan 17 2022, 6:42 AM
arsenm requested review of this revision.Jan 17 2022, 6:42 AM
Herald added a project: Restricted Project. · View Herald TranscriptJan 17 2022, 6:42 AM
Herald added a subscriber: wdng. · View Herald Transcript
foad accepted this revision.Jan 17 2022, 6:47 AM

LGTM. I always assumed it was intentional that legalization rules had to be ordered in just the right way.

This revision is now accepted and ready to land.Jan 17 2022, 6:47 AM