This is an archive of the discontinued LLVM Phabricator instance.

Differential D117292

[Driver] Pass the flag -dI to cc1 invocation
ClosedPublic

Authored by qichaogu on Jan 14 2022, 1:54 AM.

Details

Reviewers
cfe-commits
erichkeane
rsmith
Commits
rG67ac3f1fbeec: [Driver] Pass the flag -dI to cc1 invocation
Summary

Hook up the flag -dI in the driver to pass it to cc1 invocation.

Diff Detail

Event Timeline

qichaogu requested review of this revision.Jan 14 2022, 1:54 AM
qichaogu created this revision.
Harbormaster completed remote builds in B143345: Diff 399931.Jan 14 2022, 2:27 AM
erichkeane accepted this revision.Jan 14 2022, 5:53 AM
This revision is now accepted and ready to land.Jan 14 2022, 5:53 AM
qichaogu added a comment.Jan 16 2022, 5:14 PM

Could someone help commit the patch?
I don't have commit access.

hiraditya added a reviewer: rsmith.Jan 16 2022, 10:58 PM
Closed by commit rG67ac3f1fbeec: [Driver] Pass the flag -dI to cc1 invocation (authored by qichaogu, committed by erichkeane). · Explain WhyJan 18 2022, 6:16 AM
This revision was automatically updated to reflect the committed changes.
erichkeane added a commit: rG67ac3f1fbeec: [Driver] Pass the flag -dI to cc1 invocation.
Herald added a project: Restricted Project. · View Herald TranscriptJan 18 2022, 6:17 AM

Revision Contents

PathSize
clang/
lib/
Driver/
ToolChains/
1 line
test/
Driver/
8 lines

Diff 400824

clang/lib/Driver/ToolChains/Clang.cpp

  • This file is larger than 256 KB, so syntax highlighting is disabled by default.
Show First 20 Lines • Show All 6,660 Lines • ▼ Show 20 Lines if (Arg *A = Args.getLastArg(options::OPT_traditional,
if (isa<PreprocessJobAction>(JA)) if (isa<PreprocessJobAction>(JA))
CmdArgs.push_back("-traditional-cpp"); CmdArgs.push_back("-traditional-cpp");
else else
D.Diag(diag::err_drv_clang_unsupported) << A->getAsString(Args); D.Diag(diag::err_drv_clang_unsupported) << A->getAsString(Args);
} }
Args.AddLastArg(CmdArgs, options::OPT_dM); Args.AddLastArg(CmdArgs, options::OPT_dM);
Args.AddLastArg(CmdArgs, options::OPT_dD); Args.AddLastArg(CmdArgs, options::OPT_dD);
Args.AddLastArg(CmdArgs, options::OPT_dI);
Args.AddLastArg(CmdArgs, options::OPT_fmax_tokens_EQ); Args.AddLastArg(CmdArgs, options::OPT_fmax_tokens_EQ);
// Handle serialized diagnostics. // Handle serialized diagnostics.
if (Arg *A = Args.getLastArg(options::OPT__serialize_diags)) { if (Arg *A = Args.getLastArg(options::OPT__serialize_diags)) {
CmdArgs.push_back("-serialize-diagnostic-file"); CmdArgs.push_back("-serialize-diagnostic-file");
CmdArgs.push_back(Args.MakeArgString(A->getValue())); CmdArgs.push_back(Args.MakeArgString(A->getValue()));
} }
▲ Show 20 Lines • Show All 1,421 Lines • Show Last 20 Lines

clang/test/Driver/preprocessor.c

// RUN: %clang -E -x c-header %s > %t // RUN: %clang -E -x c-header %s > %t
// RUN: grep 'B B' %t // RUN: grep 'B B' %t
#define A B #define A B
A A A A
// The driver should pass preprocessor dump flags (-dD, -dM and -dI) to cc1 invocation
// RUN: %clang -### -E -dD %s 2>&1 | FileCheck --check-prefix=CHECK-dD %s
// RUN: %clang -### -E -dM %s 2>&1 | FileCheck --check-prefix=CHECK-dM %s
// RUN: %clang -### -E -dI %s 2>&1 | FileCheck --check-prefix=CHECK-dI %s
// CHECK-dD: clang{{.*}} "-cc1" {{.*}} "-dD"
// CHECK-dM: clang{{.*}} "-cc1" {{.*}} "-dM"
// CHECK-dI: clang{{.*}} "-cc1" {{.*}} "-dI"