This is an archive of the discontinued LLVM Phabricator instance.

[AMDGPU] Fix error handling in asm constraint syntax
ClosedPublic

Authored by rampitec on Jan 12 2022, 11:51 PM.

Details

Summary

I believe this is unexploitable because in either case the result
will be 'couldn't allocate register for constraint' error message,
but error code checking is clearly wrong.

Diff Detail

Event Timeline

rampitec created this revision.Jan 12 2022, 11:51 PM
rampitec requested review of this revision.Jan 12 2022, 11:51 PM
Herald added a project: Restricted Project. · View Herald TranscriptJan 12 2022, 11:51 PM
Herald added a subscriber: wdng. · View Herald Transcript
JonChesterfield accepted this revision.Jan 13 2022, 5:28 AM
This revision is now accepted and ready to land.Jan 13 2022, 5:28 AM
This revision was automatically updated to reflect the committed changes.

Testcase?

It gives exactly the same final error, finally dropping to the base implementation. The effect is unobservable.