This is an archive of the discontinued LLVM Phabricator instance.

[llvm] Fix typo for libxml2 detection
ClosedPublic

Authored by sthibaul on Jan 11 2022, 1:32 PM.

Details

Summary

This seems to be a copy-paste from the similar zlib detection code.

Diff Detail

Event Timeline

sthibaul created this revision.Jan 11 2022, 1:32 PM
sthibaul requested review of this revision.Jan 11 2022, 1:32 PM
Herald added a project: Restricted Project. · View Herald TranscriptJan 11 2022, 1:32 PM
phosek accepted this revision.Jan 11 2022, 2:06 PM

LGTM

This revision is now accepted and ready to land.Jan 11 2022, 2:06 PM

This is still not showing up on https://github.com/llvm/llvm-project/blob/main/llvm/lib/WindowsManifest/CMakeLists.txt , is there some more steps needed from my side?

Herald added a project: Restricted Project. · View Herald TranscriptMay 16 2022, 1:37 AM

I can push the change for you if you don't have commit permissions. What name and email would you like me to use?

yes, please, Samuel Thibault <samuel.thibault@ens-lyon.org> will be fine, thanks

This revision was automatically updated to reflect the committed changes.