diff --git a/mlir/include/mlir/Dialect/Arithmetic/IR/ArithmeticOps.td b/mlir/include/mlir/Dialect/Arithmetic/IR/ArithmeticOps.td --- a/mlir/include/mlir/Dialect/Arithmetic/IR/ArithmeticOps.td +++ b/mlir/include/mlir/Dialect/Arithmetic/IR/ArithmeticOps.td @@ -634,7 +634,7 @@ // MaxFOp //===----------------------------------------------------------------------===// -def Arith_MaxFOp : Arith_FloatBinaryOp<"maxf"> { +def Arith_MaxFOp : Arith_FloatBinaryOp<"maxf", [Commutative]> { let summary = "floating-point maximum operation"; let description = [{ Syntax: @@ -677,7 +677,7 @@ // MinFOp //===----------------------------------------------------------------------===// -def Arith_MinFOp : Arith_FloatBinaryOp<"minf"> { +def Arith_MinFOp : Arith_FloatBinaryOp<"minf", [Commutative]> { let summary = "floating-point minimum operation"; let description = [{ Syntax: diff --git a/mlir/test/Dialect/Arithmetic/canonicalize.mlir b/mlir/test/Dialect/Arithmetic/canonicalize.mlir --- a/mlir/test/Dialect/Arithmetic/canonicalize.mlir +++ b/mlir/test/Dialect/Arithmetic/canonicalize.mlir @@ -678,3 +678,16 @@ %res = arith.sitofp %c0 : i32 to f32 return %res : f32 } + +// ----- +// CHECK-LABEL: @constant_MinMax( +func @constant_MinMax(%arg0 : f32) -> f32 { + // CHECK: %[[const:.+]] = arith.constant + // CHECK: %[[min:.+]] = arith.minf %arg0, %[[const]] : f32 + // CHECK: %[[res:.+]] = arith.maxf %[[min]], %[[const]] : f32 + // CHECK: return %[[res]] + %const = arith.constant 0.0 : f32 + %min = arith.minf %const, %arg0 : f32 + %res = arith.maxf %const, %min : f32 + return %res : f32 +}