This is an archive of the discontinued LLVM Phabricator instance.

AMDGPU: Avoid null check during addrspacecast lowering
ClosedPublic

Authored by arsenm on Jan 4 2022, 6:38 PM.

Details

Reviewers
rampitec
Group Reviewers
Restricted Project
Summary

If we know the source is a valid object, we do not need to insert a
null check. This misses a lot of opportunities from
metadata/attributes not tracked in codegen.

Diff Detail

Unit TestsFailed

Event Timeline

arsenm created this revision.Jan 4 2022, 6:38 PM
arsenm requested review of this revision.Jan 4 2022, 6:38 PM
Herald added a project: Restricted Project. · View Herald TranscriptJan 4 2022, 6:38 PM
Herald added a subscriber: wdng. · View Herald Transcript
rampitec accepted this revision.Jan 5 2022, 9:52 AM
rampitec added a subscriber: rampitec.

LGTM

This revision is now accepted and ready to land.Jan 5 2022, 9:52 AM