[OpenMP] Add "not" to test dependencies.

[Meinersbur]

Summary

The not program is used to test executions prefixed with %libomptarget-run-fail-. Currently not is not used for libomp tests, but might be used in the future and its dependency does not add any additional burden over the already established FileCheck dependency.

Required to add libomptarget testing to the Phabricator pre-merge check (see https://github.com/google/llvm-premerge-checks/issues/368)

[JonChesterfield]

Thanks!

[jdenny]

Other than the question I added inline, LGTM.

openmp/cmake/OpenMPTesting.cmake

68

Do you know why not and FileCheck are handled differently here? It might be that D95689 simply overlooked not. @tianshilei1992?

I'm not sure if this discrepancy is relevant to the problem you're trying to fix, so maybe it should be addressed separately.

[Meinersbur]

openmp/cmake/OpenMPTesting.cmake

68

@tianshilei1992 might be the best to answer this question. However, by the motivation D95689, it seems that LLVM_INSTALL_TOOLCHAIN_ONLY applies to not and FileCheck at the same time. hence checking the existence of one implies the existence of the other.

openmp/cmake/OpenMPTesting.cmake

 else()
   if (NOT TARGET "FileCheck")
     message(STATUS "Cannot find 'FileCheck'.")
     message(WARNING "The check targets will not be available!")
     set(ENABLE_CHECK_TARGETS FALSE)
   else()
     set(OPENMP_FILECHECK_EXECUTABLE ${LLVM_RUNTIME_OUTPUT_INTDIR}/FileCheck)
   endif()
   set(OPENMP_NOT_EXECUTABLE ${LLVM_RUNTIME_OUTPUT_INTDIR}/not)
 endif()
 
 # Macro to extract information about compiler from file. (no own scope)
 macro(extract_test_compiler_information lang file)
   file(READ ${file} information)
   list(GET information 0 path)
   list(GET information 1 id)
   list(GET information 2 version)
add_custom_target(${target}
       USES_TERMINAL
     )
   else()
     if (ARG_EXCLUDE_FROM_CHECK_ALL)
       add_lit_testsuite(${target}
         ${comment}
         ${ARG_UNPARSED_ARGUMENTS}
         EXCLUDE_FROM_CHECK_ALL
-        DEPENDS clang FileCheck ${ARG_DEPENDS}
+        DEPENDS clang FileCheck not ${ARG_DEPENDS}
         ARGS ${ARG_ARGS}
       )
     else()
       add_lit_testsuite(${target}
         ${comment}
         ${ARG_UNPARSED_ARGUMENTS}
-        DEPENDS clang FileCheck ${ARG_DEPENDS}
+        DEPENDS clang FileCheck not ${ARG_DEPENDS}
         ARGS ${ARG_ARGS}
       )
     endif()
   endif()
 endfunction()
 
 function(construct_check_openmp_target)
   get_property(OPENMP_LIT_TESTSUITES GLOBAL PROPERTY OPENMP_LIT_TESTSUITES)
   get_property(OPENMP_LIT_DEPENDS GLOBAL PROPERTY OPENMP_LIT_DEPENDS)
 
   # We already added the testsuites themselves, no need to do that again.
   add_openmp_testsuite(check-openmp "Running OpenMP tests" ${OPENMP_LIT_TESTSUITES} EXCLUDE_FROM_CHECK_ALL DEPENDS ${OPENMP_LIT_DEPENDS})
 endfunction()