This is an archive of the discontinued LLVM Phabricator instance.

[AMDGPU] Do not generate ELF symbols for the local branch target labels
ClosedPublic

Authored by RamNalamothu on Nov 19 2021, 12:42 PM.

Details

Summary

The compiler was generating symbols in the final code object for local
branch target labels. This bloats the code object, slows down the loader,
and is only used to simplify disassembly.

Use '--symbolize-operands' with llvm-objdump to improve readability of the
branch target operands in disassembly.

Fixes: SWDEV-312223

Diff Detail

Event Timeline

RamNalamothu created this revision.Nov 19 2021, 12:42 PM
RamNalamothu requested review of this revision.Nov 19 2021, 12:42 PM
Herald added a project: Restricted Project. · View Herald TranscriptNov 19 2021, 12:42 PM
scott.linder accepted this revision.Nov 19 2021, 1:14 PM
This revision is now accepted and ready to land.Nov 19 2021, 1:14 PM
This revision was landed with ongoing or failed builds.Nov 19 2021, 9:02 PM
This revision was automatically updated to reflect the committed changes.

@tpr does this change break anything in LLPC?

tpr added a subscriber: critson.Nov 22 2021, 4:58 AM

@tpr does this change break anything in LLPC?

@critson identified one LLPC test that this broke because it relied on exact label names, but he has a test fix in https://github.com/GPUOpen-Drivers/llpc/pull/1533