This is an archive of the discontinued LLVM Phabricator instance.

[llvm-reduce] Assert that the number of chunks does not change with reductions
ClosedPublic

Authored by aeubanks on Nov 12 2021, 4:08 PM.

Diff Detail

Event Timeline

aeubanks requested review of this revision.Nov 12 2021, 4:08 PM
aeubanks created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptNov 12 2021, 4:08 PM
aeubanks updated this revision to Diff 386977.Nov 12 2021, 4:10 PM

remove logging

Approach looks good to me.

remove-metadata-args.ll / --delta-passes=metadata is failing, which I might have been responsible for. Do you want me to have a look?

Approach looks good to me.

remove-metadata-args.ll / --delta-passes=metadata is failing, which I might have been responsible for. Do you want me to have a look?

I have https://reviews.llvm.org/D113812 and https://reviews.llvm.org/D113808 out for that.

Meinersbur accepted this revision.Nov 15 2021, 11:23 AM

Thanks. Assuming those go in, this patch LGTM.

This revision is now accepted and ready to land.Nov 15 2021, 11:23 AM
This revision was landed with ongoing or failed builds.Dec 1 2021, 3:40 PM
This revision was automatically updated to reflect the committed changes.
foad added a subscriber: foad.Mar 2 2023, 7:35 AM
foad added inline comments.
llvm/tools/llvm-reduce/deltas/Delta.cpp
241

Hi! I've hit this assertion failure because I'm using llvm-reduce to reduce a compile-time hog, so the interestingness test ("does it take longer than 1 second to compile") is not 100% consistent. Of course it seems to me like llvm-reduce ought to support this use case. Any thoughts?

Herald added a project: Restricted Project. · View Herald TranscriptMar 2 2023, 7:35 AM
foad added inline comments.Mar 2 2023, 7:39 AM
llvm/tools/llvm-reduce/deltas/Delta.cpp
241

In any case I think this should be a proper diagnostic, not an assert, like the "Input isn't interesting!" error.

aeubanks added inline comments.Mar 6 2023, 9:30 AM
llvm/tools/llvm-reduce/deltas/Delta.cpp
241

all of what you said sounds good to me