This is an archive of the discontinued LLVM Phabricator instance.

[lldb] update TestEchoCommands
ClosedPublic

Authored by lawrence_danna on Nov 2 2021, 1:38 PM.

Download Raw Diff

Details

Reviewers

jasonmolenda
JDevlieghere
jingham
stella.stamenova

Commits

rG7f01f78593d6: [lldb] update TestEchoCommands

Summary

Followup to https://reviews.llvm.org/D112988

Sorry, I broke this test. The test was verifying the bad behavior
of --source-quietly that the previous change fixed -- namely that
it still echos the initial list of startup commands while
sourcing them.

Updated the test to verify that --source-quietly is quiet, rather than
loud.

Diff Detail

Repository: rG LLVM Github Monorepo

Event Timeline

lawrence_danna requested review of this revision.Nov 2 2021, 1:38 PM

lawrence_danna created this revision.

Herald added a project: Restricted Project. · View Herald TranscriptNov 2 2021, 1:38 PM

Herald added a subscriber: lldb-commits. · View Herald Transcript

Harbormaster completed remote builds in B132047: Diff 384208.Nov 2 2021, 1:41 PM

lawrence_danna mentioned this in D112988: [lldb] fix --source-quietly.Nov 2 2021, 1:59 PM

LGTM

This revision is now accepted and ready to land.Nov 2 2021, 2:20 PM

Closed by commit rG7f01f78593d6: [lldb] update TestEchoCommands (authored by lawrence_danna). · Explain WhyNov 2 2021, 2:30 PM

This revision was automatically updated to reflect the committed changes.

lawrence_danna added a commit: rG7f01f78593d6: [lldb] update TestEchoCommands.

stella.stamenova added inline comments.Nov 2 2021, 4:03 PM

lldb/test/Shell/Settings/TestEchoCommands.test
4	The Windows buildbot is not happy with this line: https://lab.llvm.org/buildbot/#/builders/83/builds/11630

The Windows buildbot is still broken after this change:

https://lab.llvm.org/buildbot/#/builders/83/builds/11630

In D113047#3106732, @stella.stamenova wrote:

The Windows buildbot is still broken after this change:

https://lab.llvm.org/buildbot/#/builders/83/builds/11630

sorry again :/

I will fix. It's takaing me a alittle while to get a a windows VM set up

@stella.stamenova fixed

Revision Contents

Path

Size

lldb/

test/

Shell/

Settings/

Inputs/

EchoCommandsQuiet.out

6 lines

TestEchoCommands.test

2 lines

Diff 384236

lldb/test/Shell/Settings/Inputs/EchoCommandsQuiet.out

	# CHECK: (lldb) command source -s 1 {{.*\n}}			CHECK: start
	# CHECK-NEXT: (lldb) command source -s 1 {{.*\n}}			CHECK-NOT: source
				CHECK-NOT: lldb
				CHECK-NEXT: done

lldb/test/Shell/Settings/TestEchoCommands.test

	# RUN: %lldb -x -b -o 'settings set interpreter.echo-comment-commands true' -s %S/Inputs/EchoCommandsTest.in \| FileCheck %S/Inputs/EchoCommandsAll.out			# RUN: %lldb -x -b -o 'settings set interpreter.echo-comment-commands true' -s %S/Inputs/EchoCommandsTest.in \| FileCheck %S/Inputs/EchoCommandsAll.out
	# RUN: %lldb -x -b -o 'settings set interpreter.echo-comment-commands false' -s %S/Inputs/EchoCommandsTest.in \| FileCheck %S/Inputs/EchoCommandsNoComments.out			# RUN: %lldb -x -b -o 'settings set interpreter.echo-comment-commands false' -s %S/Inputs/EchoCommandsTest.in \| FileCheck %S/Inputs/EchoCommandsNoComments.out
	# RUN: %lldb -x -b -o 'settings set interpreter.echo-commands false' -s %S/Inputs/EchoCommandsTest.in \| FileCheck %S/Inputs/EchoCommandsNone.out			# RUN: %lldb -x -b -o 'settings set interpreter.echo-commands false' -s %S/Inputs/EchoCommandsTest.in \| FileCheck %S/Inputs/EchoCommandsNone.out
	# RUN: %lldb -x -b --source-quietly -s %S/Inputs/EchoCommandsTest.in \| FileCheck %S/Inputs/EchoCommandsQuiet.out			# RUN: ( echo start ; %lldb -x -b --source-quietly -s %S/Inputs/EchoCommandsTest.in ; echo done ) \| FileCheck %S/Inputs/EchoCommandsQuiet.out
				stella.stamenovaUnsubmitted Not Done Reply Inline Actions The Windows buildbot is not happy with this line: https://lab.llvm.org/buildbot/#/builders/83/builds/11630 stella.stamenova: The Windows buildbot is not happy with this line: https://lab.llvm.