[lldb] Remove logging from Platform::~Platform

[teemperor]

Summary

Platform instances are stored in a function-local static list. However,
the logging code involves locking a function-local static mutex. This only
works on some implementations where the Log mutex is by accident
destroyed *after* the Platform list is destroyed.

This fixes randomly failing tests due to recursive_mutex lock failed: Invalid argument.

[kastiglione]

This logging doesn't seem too useful anyway.

[kastiglione]

should this be = default; now?

[aprantl]

Thanks!

[teemperor]

• defaulted dtor

[teemperor]

In D111816#3064506, @kastiglione wrote:

should this be = default; now?

Thanks, we have other functions for pinning the vtable so this seems like the way to go.

[thakis]

http://45.33.8.238/mac/37050/step_4.txt

In file included from ../../lldb/source/Plugins/Platform/POSIX/PlatformPOSIX.cpp:9:
In file included from ../../lldb/source/Plugins/Platform/POSIX/PlatformPOSIX.h:12:
In file included from ../../../chrome/src/third_party/llvm-build/Release+Asserts/bin/../include/c++/v1/map:495:
In file included from ../../../chrome/src/third_party/llvm-build/Release+Asserts/bin/../include/c++/v1/__node_handle:63:
In file included from ../../../chrome/src/third_party/llvm-build/Release+Asserts/bin/../include/c++/v1/memory:682:
In file included from ../../../chrome/src/third_party/llvm-build/Release+Asserts/bin/../include/c++/v1/__memory/shared_ptr.h:25:
../../../chrome/src/third_party/llvm-build/Release+Asserts/bin/../include/c++/v1/__memory/unique_ptr.h:50:19: error: invalid application of 'sizeof' to an incomplete type 'lldb_private::ModuleCache'
    static_assert(sizeof(_Tp) > 0,
                  ^~~~~~~~~~~
../../../chrome/src/third_party/llvm-build/Release+Asserts/bin/../include/c++/v1/__memory/unique_ptr.h:315:7: note: in instantiation of member function 'std::default_delete<lldb_private::ModuleCache>::operator()' requested here
      __ptr_.second()(__tmp);
      ^
../../../chrome/src/third_party/llvm-build/Release+Asserts/bin/../include/c++/v1/__memory/unique_ptr.h:269:19: note: in instantiation of member function 'std::unique_ptr<lldb_private::ModuleCache>::reset' requested here
  ~unique_ptr() { reset(); }
                  ^
../../lldb/include/lldb/Target/Platform.h:78:3: note: in instantiation of member function 'std::unique_ptr<lldb_private::ModuleCache>::~unique_ptr' requested here
  ~Platform() override = default;
  ^
../../lldb/include/lldb/Target/Platform.h:39:7: note: forward declaration of 'lldb_private::ModuleCache'
class ModuleCache;
      ^

[teemperor]

Fixed, thanks!

In D111816#3064923, @thakis wrote:

http://45.33.8.238/mac/37050/step_4.txt

In file included from ../../lldb/source/Plugins/Platform/POSIX/PlatformPOSIX.cpp:9:
In file included from ../../lldb/source/Plugins/Platform/POSIX/PlatformPOSIX.h:12:
In file included from ../../../chrome/src/third_party/llvm-build/Release+Asserts/bin/../include/c++/v1/map:495:
In file included from ../../../chrome/src/third_party/llvm-build/Release+Asserts/bin/../include/c++/v1/__node_handle:63:
In file included from ../../../chrome/src/third_party/llvm-build/Release+Asserts/bin/../include/c++/v1/memory:682:
In file included from ../../../chrome/src/third_party/llvm-build/Release+Asserts/bin/../include/c++/v1/__memory/shared_ptr.h:25:
../../../chrome/src/third_party/llvm-build/Release+Asserts/bin/../include/c++/v1/__memory/unique_ptr.h:50:19: error: invalid application of 'sizeof' to an incomplete type 'lldb_private::ModuleCache'
    static_assert(sizeof(_Tp) > 0,
                  ^~~~~~~~~~~
../../../chrome/src/third_party/llvm-build/Release+Asserts/bin/../include/c++/v1/__memory/unique_ptr.h:315:7: note: in instantiation of member function 'std::default_delete<lldb_private::ModuleCache>::operator()' requested here
      __ptr_.second()(__tmp);
      ^
../../../chrome/src/third_party/llvm-build/Release+Asserts/bin/../include/c++/v1/__memory/unique_ptr.h:269:19: note: in instantiation of member function 'std::unique_ptr<lldb_private::ModuleCache>::reset' requested here
  ~unique_ptr() { reset(); }
                  ^
../../lldb/include/lldb/Target/Platform.h:78:3: note: in instantiation of member function 'std::unique_ptr<lldb_private::ModuleCache>::~unique_ptr' requested here
  ~Platform() override = default;
  ^
../../lldb/include/lldb/Target/Platform.h:39:7: note: forward declaration of 'lldb_private::ModuleCache'
class ModuleCache;
      ^

lldb/include/lldb/Target/Platform.h

 ///     \li execute shell commands
 ///     \li listing and getting info for existing processes
 ///     \li attaching and possibly debugging the platform's kernel
 class Platform : public PluginInterface {
 public:
   /// Default Constructor
   Platform(bool is_host_platform);
 
-  /// Destructor.
-  ///
   /// The destructor is virtual since this class is designed to be inherited
   /// from by the plug-in instance.
-  ~Platform() override;
+  ~Platform() override = default;
 
   static void Initialize();
 
   static void Terminate();
 
   static PlatformProperties &GetGlobalPlatformProperties();
 
   /// Get the native host platform plug-in.

lldb/source/Target/Platform.cpp

: m_is_host(is_host), m_os_version_set_while_connected(false),
       m_rsync_opts(), m_rsync_prefix(), m_supports_ssh(false), m_ssh_opts(),
       m_ignores_remote_hostname(false), m_trap_handlers(),
       m_calculated_trap_handlers(false),
       m_module_cache(std::make_unique<ModuleCache>()) {
   Log *log(lldb_private::GetLogIfAllCategoriesSet(LIBLLDB_LOG_OBJECT));
   LLDB_LOGF(log, "%p Platform::Platform()", static_cast<void *>(this));
 }
 
-/// Destructor.
-///
-/// The destructor is virtual since this class is designed to be
-/// inherited from by the plug-in instance.
-Platform::~Platform() {
-  Log *log(lldb_private::GetLogIfAllCategoriesSet(LIBLLDB_LOG_OBJECT));
-  LLDB_LOGF(log, "%p Platform::~Platform()", static_cast<void *>(this));
-}
-
 void Platform::GetStatus(Stream &strm) {
   std::string s;
   strm.Printf("  Platform: %s\n", GetPluginName().GetCString());
 
   ArchSpec arch(GetSystemArchitecture());
   if (arch.IsValid()) {
     if (!arch.GetTriple().str().empty()) {
       strm.Printf("    Triple: ");