[TwoAddressInstruction] Remove ad hoc machine verification

[foad]

Summary

With the -early-live-intervals command line flag,
TwoAddressInstructionPass::runOnMachineFunction would call
MachineFunction::verify before returning to check the live intervals.
But there was not much benefit to doing this since -verify-machineinstrs
and LLVM_ENABLE_EXPENSIVE_CHECKS provide a more general way of
scheduling machine verification after every pass.

Also it caused problems on targets like Lanai which are marked as "not
machine verifier clean", since verification would fail for known
target-specific problems which are nothing to do with LiveIntervals.

[MatzeB]

LGTM

llvm/lib/CodeGen/TwoAddressInstructionPass.cpp

for (MachineBasicBlock::iterator mi = MBB->begin(), me = MBB->end();
       // Clear TiedOperands here instead of at the top of the loop
       // since most instructions do not have tied operands.
       TiedOperands.clear();
       removeClobberedSrcRegMap(&*mi);
       mi = nmi;
     }
   }
 
-  if (LIS)
-    MF->verify(this, "After two-address instruction pass");
-
   return MadeChange;
 }
 
 /// Eliminate a REG_SEQUENCE instruction as part of the de-ssa process.
 ///
 /// The instruction is turned into a sequence of sub-register copies:
 ///
 ///   %dst = REG_SEQUENCE %v1, ssub0, %v2, ssub1