This is an archive of the discontinued LLVM Phabricator instance.

[compiler-rt] Add -fno-omit-frame-pointer check to builtins
ClosedPublic

Authored by gmittert on Sep 30 2021, 1:37 PM.

Details

Summary

rG210d72e9d6b4a8e7633921d0bd7186fd3c7a2c8c moved the check from
builtin-config-ix to config-ix so that the check would be made even when
the builtins are not built. However, now the check is no longer made
when the builtins are built standalone which causes the builtins to fail
to build.

Add the check back to builtins-config-ix so that the check gets
performed both when the builtins are not built, and when they are built
standalone.

Diff Detail

Event Timeline

gmittert created this revision.Sep 30 2021, 1:37 PM
gmittert requested review of this revision.Sep 30 2021, 1:37 PM
Herald added a project: Restricted Project. · View Herald TranscriptSep 30 2021, 1:37 PM
Herald added a subscriber: Restricted Project. · View Herald Transcript
gmittert retitled this revision from [compiler-rt] Add -fno-omit-frame-pointer check to common to [compiler-rt] Add -fno-omit-frame-pointer check to builtins.Sep 30 2021, 1:38 PM
smeenai accepted this revision.Sep 30 2021, 1:50 PM

LGTM

This revision is now accepted and ready to land.Sep 30 2021, 1:50 PM
phosek accepted this revision.Sep 30 2021, 1:53 PM

LGTM