This is an archive of the discontinued LLVM Phabricator instance.

Differential D110361

[profile][fuchsia] Don't include extra NUL in log messages
ClosedPublic

Authored by mcgrathr on Sep 23 2021, 1:37 PM.

Details

Reviewers
phosek
gulfem
leonardchan
Commits
rG80b92db02c5a: [profile][fuchsia] Don't include extra NUL in log messages

Diff Detail

Event Timeline

mcgrathr requested review of this revision.Sep 23 2021, 1:37 PM
mcgrathr created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptSep 23 2021, 1:37 PM
Herald added a subscriber: Restricted Project. · View Herald Transcript
Harbormaster completed remote builds in B125428: Diff 374655.Sep 23 2021, 1:50 PM
phosek accepted this revision.Sep 23 2021, 1:51 PM

LGTM

This revision is now accepted and ready to land.Sep 23 2021, 1:51 PM
This revision was landed with ongoing or failed builds.Sep 23 2021, 3:16 PM
Closed by commit rG80b92db02c5a: [profile][fuchsia] Don't include extra NUL in log messages (authored by mcgrathr). · Explain Why
This revision was automatically updated to reflect the committed changes.
mcgrathr added a commit: rG80b92db02c5a: [profile][fuchsia] Don't include extra NUL in log messages.

Revision Contents

PathSize
compiler-rt/
lib/
profile/
2 lines

Diff 374682

compiler-rt/lib/profile/InstrProfilingPlatformFuchsia.c

Show First 20 Lines • Show All 46 Lines • ▼ Show 20 Lines
static inline void lprofWrite(const char *fmt, ...) { static inline void lprofWrite(const char *fmt, ...) {
char s[256]; char s[256];
va_list ap; va_list ap;
va_start(ap, fmt); va_start(ap, fmt);
int ret = vsnprintf(s, sizeof(s), fmt, ap); int ret = vsnprintf(s, sizeof(s), fmt, ap);
va_end(ap); va_end(ap);
__sanitizer_log_write(s, ret + 1); __sanitizer_log_write(s, ret);
} }
struct lprofVMOWriterCtx { struct lprofVMOWriterCtx {
/* VMO that contains the profile data for this module. */ /* VMO that contains the profile data for this module. */
zx_handle_t Vmo; zx_handle_t Vmo;
/* Current offset within the VMO where data should be written next. */ /* Current offset within the VMO where data should be written next. */
uint64_t Offset; uint64_t Offset;
}; };
▲ Show 20 Lines • Show All 130 Lines • Show Last 20 Lines