This is an archive of the discontinued LLVM Phabricator instance.

[Support] Implement getMainExecutable on Solaris
ClosedPublic

Authored by ro on Sep 7 2021, 10:10 AM.

Details

Summary

Many flang tests currently FAIL on Solaris because the module files aren't found. I could trace this to sys::fs::getMainExecutable not being implemented.

This patch does this and fixes all affected flang tests.

Tested on amd64-pc-solaris2.11.

Diff Detail

Event Timeline

ro created this revision.Sep 7 2021, 10:10 AM
ro requested review of this revision.Sep 7 2021, 10:10 AM
Herald added a project: Restricted Project. · View Herald TranscriptSep 7 2021, 10:10 AM
dim accepted this revision.Sep 7 2021, 10:50 AM

I can't vouch for the Solaris specific parts, but it looks sane to me. I guess you won't need to add any tests, since this will fix many now-failing tests? :)

This revision is now accepted and ready to land.Sep 7 2021, 10:50 AM
This revision was landed with ongoing or failed builds.Sep 7 2021, 1:56 PM
This revision was automatically updated to reflect the committed changes.