Page MenuHomePhabricator

[lldb] [gdb-remote client] Avoid zero padding PID/TID in H packet
ClosedPublic

Authored by mgorny on Jul 26 2021, 3:04 PM.

Details

Summary

Change SetCurrentThread*() logic not to include the zero padding
in PID/TID that was a side effect of 02ef0f5ab483. This should fix
problems caused by sending 64-bit integers to 32-bit servers. Reported
by Ted Woodward.

Diff Detail

Event Timeline

mgorny requested review of this revision.Jul 26 2021, 3:04 PM
mgorny created this revision.
mgorny retitled this revision from [lldb] [gdb-remote client] Avoid zero padding PID/TID to [lldb] [gdb-remote client] Avoid zero padding PID/TID in H packet.Jul 26 2021, 3:07 PM
ted accepted this revision.Jul 26 2021, 3:22 PM

LGTM. Thanks Michał!

This revision is now accepted and ready to land.Jul 26 2021, 3:22 PM
This revision was landed with ongoing or failed builds.Jul 26 2021, 3:44 PM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptJul 26 2021, 3:44 PM