This is an archive of the discontinued LLVM Phabricator instance.

[compiler-rt] Mark symbolize_stack_fp test unsupported on Arm Thumb
ClosedPublic

Authored by DavidSpickett on Jun 2 2021, 4:09 AM.

Details

Summary

The new test symbolize_stack_fp.cpp added in
https://reviews.llvm.org/D102046 assumes that
we can fall back to the fast unwinder.

This is not the case for Thumb and the test is currently
failing on our v7 thumb bot:
https://lab.llvm.org/buildbot/#/builders/26/builds/2096

Skip the test if we're building for a Thumb target.

Diff Detail

Event Timeline

DavidSpickett created this revision.Jun 2 2021, 4:09 AM
DavidSpickett requested review of this revision.Jun 2 2021, 4:09 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 2 2021, 4:09 AM
Herald added a subscriber: Restricted Project. · View Herald Transcript
DavidSpickett retitled this revision from [compiler-rt] Require fast unwinder for test to [compiler-rt] Require fast unwinder for symbolize_stack_fp test.Jun 2 2021, 4:21 AM
MaskRay added inline comments.Jun 2 2021, 9:41 AM
compiler-rt/test/sanitizer_common/TestCases/Linux/symbolize_stack_fp.cpp
10

Does UNSUPPORTED: thumb work? I think it is too early to generalize this to a new feature.

DavidSpickett updated this revision to Diff 349485.EditedJun 3 2021, 1:50 AM

Use thumb feature instead. (still needs a config change, there's no existing thumb feature)

DavidSpickett marked an inline comment as done.Jun 3 2021, 1:51 AM
DavidSpickett retitled this revision from [compiler-rt] Require fast unwinder for symbolize_stack_fp test to [compiler-rt] Mark symbolize_stack_fp test unsupported on Arm Thumb.Jun 3 2021, 2:06 AM
DavidSpickett edited the summary of this revision. (Show Details)
MaskRay accepted this revision.Jun 8 2021, 10:18 PM

Thanks!

This revision is now accepted and ready to land.Jun 8 2021, 10:18 PM