This is an archive of the discontinued LLVM Phabricator instance.

[compiler-rt][asan] Enable unwind-tables for Arm Linux
ClosedPublic

Authored by DavidSpickett on Jun 1 2021, 7:59 AM.

Details

Summary

Since https://reviews.llvm.org/D102046 some tests have
been falling back to fast unwinding on our Thumb bot.

This fails because fast unwinding does not work on Thumb.
By adding the extra information we ensure this does not happen
during testing, but the built library can still fast unwind
as a last resort.

Since there are some situations it can work in, like if
eveything is built with clang. During testing we've got gcc
built system libs and clang built tests.

The same change was made for sanitizer-common in
https://reviews.llvm.org/D96337.

Diff Detail

Event Timeline

DavidSpickett created this revision.Jun 1 2021, 7:59 AM
DavidSpickett requested review of this revision.Jun 1 2021, 7:59 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 1 2021, 7:59 AM
Herald added a subscriber: Restricted Project. · View Herald Transcript

Remove newline

https://lab.llvm.org/buildbot/#/builders/26/builds/2096, the sanitizer-common test needs to be handled in its own way since it's disabling things itself.

zatrazz accepted this revision.Jun 2 2021, 4:49 AM

LGTM, thanks.

This revision is now accepted and ready to land.Jun 2 2021, 4:49 AM