This is an archive of the discontinued LLVM Phabricator instance.

[sanitizer] Android ELF TLS is supported from Q (API 29)
ClosedPublic

Authored by rprichard on May 26 2021, 4:38 PM.

Diff Detail

Event Timeline

rprichard created this revision.May 26 2021, 4:38 PM
rprichard requested review of this revision.May 26 2021, 4:38 PM
Herald added a project: Restricted Project. · View Herald TranscriptMay 26 2021, 4:38 PM
Herald added a subscriber: Restricted Project. · View Herald Transcript
rprichard updated this revision to Diff 348124.May 26 2021, 4:39 PM

Update another place.

MaskRay accepted this revision.May 26 2021, 5:17 PM
MaskRay added a subscriber: MaskRay.
MaskRay added inline comments.
compiler-rt/test/sanitizer_common/TestCases/Linux/use_tls_test.cpp
4

26,28,30 -> 26,28,29,30 in test/lit.common.cfg.py

This revision is now accepted and ready to land.May 26 2021, 5:17 PM
oontvoo accepted this revision.May 27 2021, 10:57 AM

Thanks!

oontvoo added inline comments.May 27 2021, 11:06 AM
compiler-rt/test/sanitizer_common/TestCases/Linux/use_tls_test.cpp
4

around line 466:

for required in [26, 28, 30]:
  if android_api_level >= required:
    config.available_features.add('android-%s' % required)

Maybe add 27 to the list too? (now that we start caring about the odd version numbers)

This revision was landed with ongoing or failed builds.May 27 2021, 2:54 PM
This revision was automatically updated to reflect the committed changes.