This is an archive of the discontinued LLVM Phabricator instance.

[SystemZ][z/OS] Enable the AllowAtInName attribute for the HLASM dialect
ClosedPublic

Authored by anirudhp on May 25 2021, 1:15 PM.

Details

Summary
  • Currently, LLVM supports symbols of the name "token1@token2".
  • "token2" is used to identify whether an appropriate symbol reference can be used for the symbol.
  • Now, if the symbol reference couldn't be found, the AsmParser usually emits an error, unless the backend is configured to accept the "@" in a symbol name
  • Thus, this patch aims to do that. It sets the AllowAtInName attribute in the SystemZ backend for the HLASM dialect.
  • Setting this attribute ensures that, if a particular symbol reference is found, it uses that. If it doesn't, and there exists an "@" in the symbol name, it will use that instead of explicitly erroring out.

Diff Detail

Event Timeline

anirudhp created this revision.May 25 2021, 1:15 PM
anirudhp requested review of this revision.May 25 2021, 1:15 PM
Herald added a project: Restricted Project. · View Herald TranscriptMay 25 2021, 1:15 PM
uweigand accepted this revision.May 26 2021, 3:10 AM

LGTM.

This revision is now accepted and ready to land.May 26 2021, 3:10 AM