This is an archive of the discontinued LLVM Phabricator instance.

[lldb][NFC] Don't depend on Clang libraries from selected core libraries
Changes PlannedPublic

Authored by teemperor on May 25 2021, 9:08 AM.

Details

Summary

Alex Langford removed all the Clang dependencies from the core libraries (thanks!), so we can finally
drop them from the linker flags. We still depend on the Clang tablegen headers
to be generated (which is automatically added to all LLDB targets), but otherwise
building core libraries/tests no longer requires to build Clang.

Diff Detail

Event Timeline

teemperor created this revision.May 25 2021, 9:08 AM
teemperor requested review of this revision.May 25 2021, 9:08 AM

Also yes, Alex did all the work to make this happen and I am now pushing this over the finish line. This is known as a "pro gamer move" ;)

teemperor edited the summary of this revision. (Show Details)May 25 2021, 9:09 AM
teemperor edited the summary of this revision. (Show Details)
teemperor planned changes to this revision.May 25 2021, 9:12 AM

Arg, nevermind, I built in the wrong directory... I thought we're already there, but there are a few dependencies still left.

Arg, nevermind, I built in the wrong directory... I thought we're already there, but there are a few dependencies still left.

Yeah, there are a few particularly non-trivial dependencies left. Not so obvious how to fix them right now, but I've got a few ideas in my head. We can chat and figure out how to best decouple things.