Index: include/llvm/Object/Error.h =================================================================== --- include/llvm/Object/Error.h +++ include/llvm/Object/Error.h @@ -29,6 +29,8 @@ unexpected_eof, bitcode_section_not_found, macho_small_load_command, + macho_load_segment_too_many_sections, + macho_load_segment_too_small, }; inline std::error_code make_error_code(object_error e) { Index: lib/Object/Error.cpp =================================================================== --- lib/Object/Error.cpp +++ lib/Object/Error.cpp @@ -46,6 +46,10 @@ return "Bitcode section not found in object file"; case object_error::macho_small_load_command: return "Mach-O load command with size < 8 bytes"; + case object_error::macho_load_segment_too_many_sections: + return "Mach-O segment load command contains too many sections"; + case object_error::macho_load_segment_too_small: + return "Mach-O segment load command size is too small"; } llvm_unreachable("An enumerator of object_error does not have a message " "defined."); Index: lib/Object/MachOObjectFile.cpp =================================================================== --- lib/Object/MachOObjectFile.cpp +++ lib/Object/MachOObjectFile.cpp @@ -66,17 +66,16 @@ } template -static uint32_t getSegmentLoadCommandNumSections(const SegmentCmd &S, - uint32_t Cmdsize) { +static ErrorOr getSegmentLoadCommandNumSections(const SegmentCmd &S, + uint32_t Cmdsize) { const unsigned SectionSize = sizeof(SegmentCmd); if (S.nsects > std::numeric_limits::max() / SectionSize || S.nsects * SectionSize > Cmdsize - sizeof(S)) - report_fatal_error( - "Number of sections too large for size of load command."); + return object_error::macho_load_segment_too_many_sections; return S.nsects; } -static uint32_t +static ErrorOr getSegmentLoadCommandNumSections(const MachOObjectFile *O, const MachOObjectFile::LoadCommandInfo &L) { if (O->is64Bit()) @@ -305,14 +304,19 @@ } UuidLoadCmd = Load.Ptr; } else if (Load.C.cmd == SegmentLoadType) { - const unsigned SegmentLoadSize = this->is64Bit() + const unsigned SegmentLoadSize = is64Bit() ? sizeof(MachO::segment_command_64) : sizeof(MachO::segment_command); - if (Load.C.cmdsize < SegmentLoadSize) - report_fatal_error("Segment load command size is too small."); - - uint32_t NumSections = getSegmentLoadCommandNumSections(this, Load); - for (unsigned J = 0; J < NumSections; ++J) { + if (Load.C.cmdsize < SegmentLoadSize) { + EC = object_error::macho_load_segment_too_small; + return; + } + auto NumSectionsOrErr = getSegmentLoadCommandNumSections(this, Load); + if (!NumSectionsOrErr) { + EC = NumSectionsOrErr.getError(); + return; + } + for (unsigned J = 0; J < NumSectionsOrErr.get(); ++J) { const char *Sec = getSectionPtr(this, Load, J); Sections.push_back(Sec); } Index: test/Object/macho-invalid.test =================================================================== --- test/Object/macho-invalid.test +++ test/Object/macho-invalid.test @@ -11,17 +11,17 @@ RUN: | FileCheck -check-prefix SMALL-LOADC-SIZE %s SMALL-LOADC-SIZE: Mach-O load command with size < 8 bytes -RUN: not llvm-objdump -private-headers %p/Inputs/macho-invalid-too-small-segment-load-command 2>&1 \ +RUN: llvm-objdump -private-headers %p/Inputs/macho-invalid-too-small-segment-load-command 2>&1 \ RUN: | FileCheck -check-prefix SMALL-SEGLOADC-SIZE %s -RUN: not llvm-objdump -private-headers %p/Inputs/macho64-invalid-too-small-segment-load-command 2>&1 \ +RUN: llvm-objdump -private-headers %p/Inputs/macho64-invalid-too-small-segment-load-command 2>&1 \ RUN: | FileCheck -check-prefix SMALL-SEGLOADC-SIZE %s -SMALL-SEGLOADC-SIZE: Segment load command size is too small +SMALL-SEGLOADC-SIZE: Mach-O segment load command size is too small -RUN: not llvm-objdump -private-headers %p/Inputs/macho-invalid-no-size-for-sections 2>&1 \ +RUN: llvm-objdump -private-headers %p/Inputs/macho-invalid-no-size-for-sections 2>&1 \ RUN: | FileCheck -check-prefix TOO-MANY-SECTS %s -RUN: not llvm-objdump -private-headers %p/Inputs/macho64-invalid-no-size-for-sections 2>&1 \ +RUN: llvm-objdump -private-headers %p/Inputs/macho64-invalid-no-size-for-sections 2>&1 \ RUN: | FileCheck -check-prefix TOO-MANY-SECTS %s -TOO-MANY-SECTS: Number of sections too large for size of load command +TOO-MANY-SECTS: Mach-O segment load command contains too many sections RUN: not llvm-objdump -t %p/Inputs/macho-invalid-bad-symbol-index 2>&1 \ RUN: | FileCheck -check-prefix BAD-SYMBOL %s