This is an archive of the discontinued LLVM Phabricator instance.

Differential D101655

[debugserver] Include LLDB_VERSION_SUFFIX in debugserver version
ClosedPublic

Authored by JDevlieghere on Apr 30 2021, 12:05 PM.

Details

Reviewers
jasonmolenda
Commits
rG2d5d720df0bb: [debugserver] Include LLDB_VERSION_SUFFIX in debugserver version

Diff Detail

Event Timeline

JDevlieghere requested review of this revision.Apr 30 2021, 12:05 PM
JDevlieghere created this revision.
JDevlieghere added inline comments.
lldb/tools/debugserver/source/debugserver_vers.c.in
1

The missing dot here is intentional, it's part of the suffix.

Harbormaster completed remote builds in B101994: Diff 342002.Apr 30 2021, 3:03 PM
jasonmolenda accepted this revision.May 3 2021, 3:02 PM

Yep looks good.

This revision is now accepted and ready to land.May 3 2021, 3:02 PM
Closed by commit rG2d5d720df0bb: [debugserver] Include LLDB_VERSION_SUFFIX in debugserver version (authored by JDevlieghere). · Explain WhyMay 3 2021, 3:05 PM
This revision was automatically updated to reflect the committed changes.
JDevlieghere added a commit: rG2d5d720df0bb: [debugserver] Include LLDB_VERSION_SUFFIX in debugserver version.
Herald added a project: Restricted Project. · View Herald TranscriptMay 3 2021, 3:05 PM

Revision Contents

PathSize
lldb/
tools/
debugserver/
source/
2 lines

Diff 342558

lldb/tools/debugserver/source/debugserver_vers.c.in

const unsigned char debugserverVersionString[] __attribute__ ((used)) = "@(#)PROGRAM:LLDB PROJECT:lldb-@LLDB_VERSION_MAJOR@.@LLDB_VERSION_MINOR@.@LLDB_VERSION_PATCH@" "\n"; const unsigned char debugserverVersionString[] __attribute__ ((used)) = "@(#)PROGRAM:LLDB PROJECT:lldb-@LLDB_VERSION_MAJOR@.@LLDB_VERSION_MINOR@.@LLDB_VERSION_PATCH@@LLDB_VERSION_SUFFIX@" "\n";
JDevlieghereAuthorUnsubmitted
Done
ReplyInline Actions

The missing dot here is intentional, it's part of the suffix.

JDevlieghere: The missing dot here is intentional, it's part of the suffix.
const double debugserverVersionNumber __attribute__ ((used)) = (double)@LLDB_VERSION_MAJOR@.@LLDB_VERSION_MINOR@; const double debugserverVersionNumber __attribute__ ((used)) = (double)@LLDB_VERSION_MAJOR@.@LLDB_VERSION_MINOR@;