This is an archive of the discontinued LLVM Phabricator instance.

Differential D10043

Add 'qXfer:features:read' to known stub list
ClosedPublic

Authored by chying on May 26 2015, 3:19 PM.

Details

Reviewers
sivachandra
vharron
clayborg
Commits
rG294c92651c6e: Add 'qXfer:features:read' to known stub list
rLLDB238262: Add 'qXfer:features:read' to known stub list
rL238262: Add 'qXfer:features:read' to known stub list
Summary

-Fix darwin bot failure "unknown qSupported stub feature reported: qXfer:features:read"
-TestGdbRemoteAuxvSupport.py and TestLldbGdbServer.py were affected by this problem

Diff Detail

Event Timeline

chying updated this revision to Diff 26543.May 26 2015, 3:19 PM
chying retitled this revision from to Add 'qXfer:features:read' to known stub list.
chying updated this object.
chying edited the test plan for this revision. (Show Details)
chying added reviewers: clayborg, sivachandra, vharron.
chying added a subscriber: Unknown Object (MLST).
clayborg accepted this revision.May 26 2015, 3:48 PM
clayborg edited edge metadata.

Looks good.

This revision is now accepted and ready to land.May 26 2015, 3:48 PM
Closed by commit rL238262: Add 'qXfer:features:read' to known stub list (authored by chying). · Explain WhyMay 26 2015, 4:11 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
test/
tools/
lldb-server/
1 line

Diff 26543

test/tools/lldb-server/gdbremote_testcase.py

Show First 20 Lines • Show All 710 Lines • ▼ Show 20 Lines _KNOWN_QSUPPORTED_STUB_FEATURES = [
"augmented-libraries-svr4-read", "augmented-libraries-svr4-read",
"PacketSize", "PacketSize",
"QStartNoAckMode", "QStartNoAckMode",
"QThreadSuffixSupported", "QThreadSuffixSupported",
"QListThreadsInStopReply", "QListThreadsInStopReply",
"qXfer:auxv:read", "qXfer:auxv:read",
"qXfer:libraries:read", "qXfer:libraries:read",
"qXfer:libraries-svr4:read", "qXfer:libraries-svr4:read",
"qXfer:features:read",
] ]
def parse_qSupported_response(self, context): def parse_qSupported_response(self, context):
self.assertIsNotNone(context) self.assertIsNotNone(context)
raw_response = context.get("qSupported_response") raw_response = context.get("qSupported_response")
self.assertIsNotNone(raw_response) self.assertIsNotNone(raw_response)
▲ Show 20 Lines • Show All 542 Lines • Show Last 20 Lines