This is an archive of the discontinued LLVM Phabricator instance.

[ifs][elfabi] Merge llvm-ifs/elfabi tools
ClosedPublic

Authored by haowei on Apr 8 2021, 2:11 PM.

Details

Summary

This change merges llvm-elfabi and llvm-ifs tools.

Diff Detail

Event Timeline

haowei created this revision.Apr 8 2021, 2:11 PM
haowei requested review of this revision.Apr 8 2021, 2:11 PM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptApr 8 2021, 2:11 PM
haowei updated this revision to Diff 343780.May 7 2021, 4:19 PM

Rebase the change to resolve presubmit errors.

phosek accepted this revision.Jun 13 2021, 4:09 PM

LGTM

clang/lib/Driver/ToolChains/InterfaceStubs.cpp
18

Ideally, this job would use the IFS library to construct .ifs or stub file directly without invoking an external tool. Can you please leave a TODO here along those lines?

llvm/tools/llvm-ifs/llvm-ifs.cpp
47–48

Ideally we would use OptTable for option parsing, can you please leave a TODO comment here along those lines?

263–264
414

No need for { and } here and below since each if has only one statement.

This revision is now accepted and ready to land.Jun 13 2021, 4:09 PM
haowei updated this revision to Diff 353507.Jun 21 2021, 4:00 PM
haowei marked 3 inline comments as done.
haowei marked an inline comment as done.
This revision was landed with ongoing or failed builds.Jul 19 2021, 11:24 AM
This revision was automatically updated to reflect the committed changes.
llvm/utils/gn/secondary/llvm/test/BUILD.gn