Index: cfe/trunk/lib/ARCMigrate/ObjCMT.cpp =================================================================== --- cfe/trunk/lib/ARCMigrate/ObjCMT.cpp +++ cfe/trunk/lib/ARCMigrate/ObjCMT.cpp @@ -214,25 +214,15 @@ // FIXME. This duplicates one in RewriteObjCFoundationAPI.cpp bool subscriptOperatorNeedsParens(const Expr *FullExpr) { const Expr* Expr = FullExpr->IgnoreImpCasts(); - if (isa(Expr) || - isa(Expr) || - isa(Expr) || - isa(Expr) || - isa(Expr) || - isa(Expr) || - isa(Expr) || - isa(Expr) || - isa(Expr) || - isa(Expr) || - isa(Expr) || - isa(Expr) || - isa(Expr) || - isa(FullExpr) || - isa(Expr) || - isa(Expr)) - return false; - - return true; + return !(isa(Expr) || isa(Expr) || + isa(Expr) || isa(Expr) || + isa(Expr) || isa(Expr) || + isa(Expr) || + isa(Expr) || + isa(Expr) || isa(Expr) || + isa(Expr) || isa(Expr) || + isa(Expr) || isa(FullExpr) || + isa(Expr) || isa(Expr)); } /// \brief - Rewrite message expression for Objective-C setter and getters into @@ -665,9 +655,7 @@ return false; } } - if (HasAtleastOneRequiredProperty || HasAtleastOneRequiredMethod) - return true; - return false; + return HasAtleastOneRequiredProperty || HasAtleastOneRequiredMethod; } static bool rewriteToObjCInterfaceDecl(const ObjCInterfaceDecl *IDecl, Index: cfe/trunk/lib/ARCMigrate/TransEmptyStatementsAndDealloc.cpp =================================================================== --- cfe/trunk/lib/ARCMigrate/TransEmptyStatementsAndDealloc.cpp +++ cfe/trunk/lib/ARCMigrate/TransEmptyStatementsAndDealloc.cpp @@ -104,9 +104,7 @@ return false; if (!S->getThen() || !Visit(S->getThen())) return false; - if (S->getElse() && !Visit(S->getElse())) - return false; - return true; + return !S->getElse() || Visit(S->getElse()); } bool VisitWhileStmt(WhileStmt *S) { if (S->getConditionVariable()) Index: cfe/trunk/lib/ARCMigrate/TransGCAttrs.cpp =================================================================== --- cfe/trunk/lib/ARCMigrate/TransGCAttrs.cpp +++ cfe/trunk/lib/ARCMigrate/TransGCAttrs.cpp @@ -152,9 +152,7 @@ return ID->getImplementation() != nullptr; if (ObjCCategoryDecl *CD = dyn_cast(ContD)) return CD->getImplementation() != nullptr; - if (isa(ContD)) - return true; - return false; + return isa(ContD); } return false; } Index: cfe/trunk/lib/ARCMigrate/TransRetainReleaseDealloc.cpp =================================================================== --- cfe/trunk/lib/ARCMigrate/TransRetainReleaseDealloc.cpp +++ cfe/trunk/lib/ARCMigrate/TransRetainReleaseDealloc.cpp @@ -150,11 +150,8 @@ return true; } - if (!hasSideEffects(rec, Pass.Ctx)) { - if (tryRemoving(RecContainer)) - return true; - } - Pass.TA.replace(RecContainer->getSourceRange(), RecRange); + if (hasSideEffects(rec, Pass.Ctx) || !tryRemoving(RecContainer)) + Pass.TA.replace(RecContainer->getSourceRange(), RecRange); return true; } @@ -174,11 +171,8 @@ /// return var; /// bool isCommonUnusedAutorelease(ObjCMessageExpr *E) { - if (isPlusOneAssignBeforeOrAfterAutorelease(E)) - return true; - if (isReturnedAfterAutorelease(E)) - return true; - return false; + return isPlusOneAssignBeforeOrAfterAutorelease(E) || + isReturnedAfterAutorelease(E); } bool isReturnedAfterAutorelease(ObjCMessageExpr *E) { @@ -225,11 +219,7 @@ // Check for "RefD = [+1 retained object];". if (BinaryOperator *Bop = dyn_cast(S)) { - if (RefD != getReferencedDecl(Bop->getLHS())) - return false; - if (isPlusOneAssign(Bop)) - return true; - return false; + return (RefD == getReferencedDecl(Bop->getLHS())) && isPlusOneAssign(Bop); } if (DeclStmt *DS = dyn_cast(S)) { Index: cfe/trunk/lib/ARCMigrate/Transforms.cpp =================================================================== --- cfe/trunk/lib/ARCMigrate/Transforms.cpp +++ cfe/trunk/lib/ARCMigrate/Transforms.cpp @@ -113,10 +113,7 @@ while (implCE && implCE->getCastKind() == CK_BitCast) implCE = dyn_cast(implCE->getSubExpr()); - if (implCE && implCE->getCastKind() == CK_ARCConsumeObject) - return true; - - return false; + return implCE && implCE->getCastKind() == CK_ARCConsumeObject; } /// \brief 'Loc' is the end of a statement range. This returns the location