Page MenuHomePhabricator

Recent Activity

Today

Mordante added inline comments to D85612: [Sema] Use proper integral cast for an enumerate with a fixed bool type.
Fri, Aug 14, 9:46 AM · Restricted Project
zacharyselk requested review of D85978: [clang-tools-extra] Added missing comma.
Fri, Aug 14, 9:46 AM · Restricted Project
aemerson updated the diff for D85965: [GlobalISel] Add a combine for ashr(shl x, c), c --> sext_inreg x, c'.
Fri, Aug 14, 9:45 AM · Restricted Project
dp added a comment to D85941: AMDGPU: Correct definitions for global saddr instructions.

This change fixes bug 35436.
https://bugs.llvm.org/show_bug.cgi?id=35436

Fri, Aug 14, 9:45 AM · Restricted Project
lhames accepted D84787: [SystemZ/ZOS] __(de)register_frame are not available on z/OS..

Sorry I missed this one earlier. Looks good to me too.

Fri, Aug 14, 9:45 AM · Restricted Project
aemerson added inline comments to D85966: [GlobalISel] Add a combine for sext_inreg(load x), c --> sextload x.
Fri, Aug 14, 9:43 AM · Restricted Project
yln committed rGd137db80297f: [TSan][libdispatch] Add interceptors for dispatch_async_and_wait() (authored by yln).
[TSan][libdispatch] Add interceptors for dispatch_async_and_wait()
Fri, Aug 14, 9:40 AM
yln closed D85854: [TSan][libdispatch] Add interceptors for dispatch_async_and_wait().
Fri, Aug 14, 9:40 AM · Restricted Project
oontvoo updated the diff for D85927: Enable LSAN for Android.

updated

Fri, Aug 14, 9:36 AM · Restricted Project
mehdi_amini committed rG059cb8b3c9f0: Remove dependency from lib/CAPI/IR/IR.cpp on registerAllDialects() (build fix) (authored by mehdi_amini).
Remove dependency from lib/CAPI/IR/IR.cpp on registerAllDialects() (build fix)
Fri, Aug 14, 9:36 AM
fpetrogalli requested review of D85977: [release][docs] Update contributions to LLVM 11 for SVE..
Fri, Aug 14, 9:36 AM · Restricted Project, Restricted Project
arsenm added a comment to D85965: [GlobalISel] Add a combine for ashr(shl x, c), c --> sext_inreg x, c'.

Seems like it's missing a legality check, although I'm unclear on what the overall strategy for those is supposed to be

This is intended to run prelegalizer so I don't think we need it.

Fri, Aug 14, 9:34 AM · Restricted Project
JDevlieghere requested review of D85976: [lldb] Get rid of helper CMake variables for Python.
Fri, Aug 14, 9:31 AM
aemerson added a comment to D85965: [GlobalISel] Add a combine for ashr(shl x, c), c --> sext_inreg x, c'.

Seems like it's missing a legality check, although I'm unclear on what the overall strategy for those is supposed to be

Fri, Aug 14, 9:31 AM · Restricted Project
fhahn added a comment to D85473: [Clang] Add option to allow marking pass-by-value args as noalias..

ping

Fri, Aug 14, 9:27 AM · Restricted Project
hiraditya added a comment to D79485: [BPI] Improve static heuristics for "cold" paths..

please run clang-format.

Fri, Aug 14, 9:24 AM · Restricted Project
hiraditya added a comment to D79485: [BPI] Improve static heuristics for "cold" paths..

..anyway I can try to describe how thing work using some example. Is this what you are looking for?

yes. Thank you.

Fri, Aug 14, 9:23 AM · Restricted Project
arsenm added inline comments to D85966: [GlobalISel] Add a combine for sext_inreg(load x), c --> sextload x.
Fri, Aug 14, 9:23 AM · Restricted Project
hubert.reinterpretcast accepted D83866: [SystemZ/ZOS] Additions to the build system..

LGTM; thanks.

Fri, Aug 14, 9:22 AM · Restricted Project
paquette accepted D85966: [GlobalISel] Add a combine for sext_inreg(load x), c --> sextload x.

LGTM with a couple nits on comments

Fri, Aug 14, 9:20 AM · Restricted Project
yaxunl added inline comments to D84822: Add documentation for target ID and ClangOffloadBundlerFormat.
Fri, Aug 14, 9:18 AM · Restricted Project
xbolva00 added inline comments to D85963: [SLC] sprintf(dst, "%s", str) -> strcpy(dst, str).
Fri, Aug 14, 9:18 AM · Restricted Project
xbolva00 added a comment to D85963: [SLC] sprintf(dst, "%s", str) -> strcpy(dst, str).

In the case where we need the return value, there are a couple possible modifications:

  1. Maybe worth checking if the length of the string is a known constant.
  2. We could consider using stpcpy on targets where it's available.
Fri, Aug 14, 9:14 AM · Restricted Project
xbolva00 added inline comments to D85963: [SLC] sprintf(dst, "%s", str) -> strcpy(dst, str).
Fri, Aug 14, 9:14 AM · Restricted Project
xbolva00 updated the diff for D85963: [SLC] sprintf(dst, "%s", str) -> strcpy(dst, str).

Implemented suggested transformations.

Fri, Aug 14, 9:13 AM · Restricted Project
hubert.reinterpretcast added inline comments to D85774: [XCOFF][AIX] Enable tooling support for 64 bit symbol table parsing.
Fri, Aug 14, 9:12 AM · Restricted Project
JDevlieghere accepted D85820: Use find_library for ncurses.

One more comment about the duplicated find_library line, but otherwise this LGTM.

Fri, Aug 14, 9:12 AM · Restricted Project
sgraenitz committed rG63aed9cbe5b0: [ORC] Build LLJITWithChildProcess example only on UNIX host systems (authored by sgraenitz).
[ORC] Build LLJITWithChildProcess example only on UNIX host systems
Fri, Aug 14, 9:09 AM
hiraditya requested review of D85975: [NFC] Fix typo and variable names.
Fri, Aug 14, 9:08 AM · Restricted Project
kcc added a comment to D85947: [DFSan] Don't unmap during dfsan_flush()..

Would it be possible to add a threaded test that fails w/o this change?
LGTM otherwise, thanks!

Fri, Aug 14, 9:05 AM · Restricted Project
sivachandra accepted D85945: [libc] Add restrict qualifiers to string library; give consistent naming scheme to TableGen files..
Fri, Aug 14, 9:05 AM · Restricted Project
hubert.reinterpretcast accepted D85527: [AIX] Generate unique module id based on PID and timestamp.

Thanks; this LGTM with comments. Please double check to make sure the capitalization of clangPidTime is consistent (including in comments) if making that change.

Fri, Aug 14, 9:03 AM · Restricted Project
MaskRay accepted D85651: [LLD][ELF] - Do not produce an invalid dynamic relocation order with --shuffle-sections..

Looks great!

Fri, Aug 14, 9:02 AM
yln added a comment to D85854: [TSan][libdispatch] Add interceptors for dispatch_async_and_wait().

LGTM. Maybe add an if to check if the 10.14-only API is available and just do nothing in the test otherwise?

Fri, Aug 14, 9:01 AM · Restricted Project
MrHate added a comment to D85284: [lldb] Remote disk file/directory completion for platform commands.

Now the server test works well except that the lldb-server subprocess cannot be terminated gracefully due to a TypeError thrown by sock.sendall(GdbRemoteTestCaseBase._GDBREMOTE_KILL_PACKET) in shutdown_socket, the backtrace is

Traceback (most recent call last):
  File "/home/ubuntu/llvm-project/lldb/packages/Python/lldbsuite/test/tools/lldb-server/gdbremote_testcase.py", line 349, in shutdown_socket
    sock.sendall(GdbRemoteTestCaseBase._GDBREMOTE_KILL_PACKET)
TypeError: a bytes-like object is required, not 'str'

Interesting. This isn't really related to your patch, is it (like, I would expect all gdb-remote tests to suffer from this python3 incompatibility)? I'll try to take a look at this later today, but if the test comes out as successful I don't think you have to wait for that. The patch looks good to me, aside from some small clarifications in inline comments.

That should be fixed by e6b1b61054.

Fri, Aug 14, 8:54 AM · Restricted Project
MaskRay added inline comments to D85798: Split Preprocessor/init.c test. NFC..
Fri, Aug 14, 8:54 AM · Restricted Project
erichkeane added a comment to D74361: [Clang] Undef attribute for global variables.

Yep! Declaring a global variable that isn't 'extern' with an incomplete type is disallowed anyway, so if you call RequireCompleteType, you're likely just diagnosing that early.

Fri, Aug 14, 8:53 AM · Restricted Project
JDevlieghere committed rGce439cb1c962: [lldb] Remove Python 2 fallback and only support Python 3 (authored by JDevlieghere).
[lldb] Remove Python 2 fallback and only support Python 3
Fri, Aug 14, 8:50 AM
ebevhan commandeered D54749: Saturating float to int casts: Basics [1/n].
Fri, Aug 14, 8:50 AM · Restricted Project
JDevlieghere closed D85942: [lldb] Remove Python 2 fallback and make Python 3 the only supported configuration..
Fri, Aug 14, 8:50 AM · Restricted Project